You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/04/30 15:00:21 UTC
[GitHub] [geode] sabbeyPivotal opened a new pull request #5026: GEODE-8051: Create multi-node concurrency (distributed) tests for HSET and HMSET
sabbeyPivotal opened a new pull request #5026:
URL: https://github.com/apache/geode/pull/5026
HSET (https://redis.io/commands/hset) and HMSET (https://redis.io/commands/hmset) set fields and values on hashes. We created distributed tests to ensure HSET and HMSET can happen concurrently on multiple servers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5026: GEODE-8051: Create multi-node concurrency (distributed) tests for HSET and HMSET
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5026:
URL: https://github.com/apache/geode/pull/5026#discussion_r418229399
##########
File path: geode-redis/src/commonTest/java/org/apache/geode/redis/ConcurrentLoopingThreads.java
##########
@@ -1,19 +1,24 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
- * agreements. See the NOTICE file distributed with this work for additional information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
- * or implied. See the License for the specific language governing permissions and limitations under
- * the License.
- */
-
-package org.apache.geode.redis.general;
+package org.apache.geode.redis;/*
Review comment:
Fixed it. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5026: GEODE-8051: Create multi-node concurrency (distributed) tests for HSET and HMSET
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5026:
URL: https://github.com/apache/geode/pull/5026#discussion_r418225974
##########
File path: geode-redis/src/commonTest/java/org/apache/geode/redis/ConcurrentLoopingThreads.java
##########
@@ -1,19 +1,24 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
- * agreements. See the NOTICE file distributed with this work for additional information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
- * or implied. See the License for the specific language governing permissions and limitations under
- * the License.
- */
-
-package org.apache.geode.redis.general;
+package org.apache.geode.redis;/*
Review comment:
fix indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org