You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:02:22 UTC
[GitHub] [cloudstack] apurv-1 opened a new pull request #5200: UI: Autoscroll to Error Field
apurv-1 opened a new pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200
### Description
Issue #4798
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Screenshots (if appropriate):
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-907684771
@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-878228502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-881419307
Hi @apurv-1 can you please fix the conflicts. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-879635595
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5200 (SL-JID-356)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-907684692
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-907685314
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5200 (SL-JID-572)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-902971004
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-902971087
@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti closed pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
sureshanaparti closed pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on a change in pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on a change in pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#discussion_r684193002
##########
File path: ui/src/views/compute/DeployVM.vue
##########
@@ -1419,7 +1424,7 @@ export default {
})
return
}
-
+ // console.log(err.zoneid.errors[0])
Review comment:
Yeah, sorry will fix it asap!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-879633715
@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-879633224
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-972643738
Merged this as it appears this has been already tested by @borisstoyanov and others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-878228316
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#discussion_r684183858
##########
File path: ui/src/views/compute/DeployVM.vue
##########
@@ -1419,7 +1424,7 @@ export default {
})
return
}
-
+ // console.log(err.zoneid.errors[0])
Review comment:
let's not put code in comments. we have git to stash or archive code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-902972843
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5200 (SL-JID-543)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] apurv-1 commented on pull request #5200: UI: Autoscroll to Error Field
Posted by GitBox <gi...@apache.org>.
apurv-1 commented on pull request #5200:
URL: https://github.com/apache/cloudstack/pull/5200#issuecomment-881843713
Done @sureshanaparti
> Hi @apurv-1 can you please fix the conflicts. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org