[GitHub] [flink] godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407858281
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
 ##########
 @@ -130,7 +139,12 @@
 			"Unsupported SQL query! sqlUpdate() only accepts a single SQL statement of type " +
 			"INSERT, CREATE TABLE, DROP TABLE, ALTER TABLE, USE CATALOG, USE [CATALOG.]DATABASE, " +
 			"CREATE DATABASE, DROP DATABASE, ALTER DATABASE, CREATE FUNCTION, " +
-			"DROP FUNCTION, ALTER FUNCTION";
+			"DROP FUNCTION, ALTER FUNCTION, CREATE CATALOG.";
+	private static final String UNSUPPORTED_QUERY_IN_EXECUTE_SQL_MSG =
 
 Review comment:
   `INSERT` and `EXPLAIN` will be supported after we correct batch table environment execution behavior which contains two parts: one is "Introduce PlanGenerator" which is [reviewing](https://github.com/apache/flink/pull/11671), and another is "Correct the execution behavior of BatchTableEnvironment" ([FLINK-17126](https://issues.apache.org/jira/browse/FLINK-17126)). `SELECT` will be supported after the design of `FLINK-14807` is ready (depend on `OperatorCoordinator`). If `FLINK-14807` is not ready in the later this month, we can support `SELECT` based on the approach of sql client (get batch result from accumulator , and get streaming result through socket)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services