You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/11/23 20:11:07 UTC
svn commit: r1895276 - in /poi/trunk/poi/src: main/java/org/apache/poi/util/XMLHelper.java test/java/org/apache/poi/util/TestXMLHelper.java
Author: fanningpj
Date: Tue Nov 23 20:11:07 2021
New Revision: 1895276
URL: http://svn.apache.org/viewvc?rev=1895276&view=rev
Log:
[bug-65700] do not warn if transformer factory does not support accessExternalDTD property
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java
poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
Modified: poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java?rev=1895276&r1=1895275&r2=1895276&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/util/XMLHelper.java Tue Nov 23 20:11:07 2021
@@ -221,7 +221,7 @@ public final class XMLHelper {
public static TransformerFactory getTransformerFactory() {
TransformerFactory factory = TransformerFactory.newInstance();
trySet(factory::setFeature, FEATURE_SECURE_PROCESSING, true);
- trySet(factory::setAttribute, ACCESS_EXTERNAL_DTD, "");
+ quietSet(factory::setAttribute, ACCESS_EXTERNAL_DTD, "");
trySet(factory::setAttribute, ACCESS_EXTERNAL_STYLESHEET, "");
quietSet(factory::setAttribute, ACCESS_EXTERNAL_SCHEMA, "");
return factory;
Modified: poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java?rev=1895276&r1=1895275&r2=1895276&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java Tue Nov 23 20:11:07 2021
@@ -158,4 +158,12 @@ class TestXMLHelper {
void testNewXMLEventFactory() {
assertNotNull(XMLHelper.newXMLEventFactory());
}
+
+ /**
+ * test that newTransformer returns a transformer
+ */
+ @Test
+ void testNewTransformer() throws Exception {
+ assertNotNull(XMLHelper.newTransformer());
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org