[GitHub] [linkis] GuoPhilipse commented on a diff in pull request #4278: [feat] EngineConn no longer imports the dependencies of the underlying engine

["GuoPhilipse (via GitHub)" <gi...@apache.org>]

GuoPhilipse commented on code in PR #4278:
URL: https://github.com/apache/linkis/pull/4278#discussion_r1125495006


##########
linkis-engineconn-plugins/spark/src/main/scala/org/apache/linkis/engineplugin/spark/Interpreter/ProcessInterpreter.scala:
##########
@@ -33,8 +33,6 @@ import java.util.concurrent.TimeUnit
 import scala.concurrent.{Await, ExecutionContext, Future}
 import scala.concurrent.duration.Duration
 
-import org.json4s._
-
 /**
  */
 abstract class ProcessInterpreter(process: Process) extends Interpreter with Logging {

Review Comment:
   seems `PythonInterpreter` still extends from `ProcessInterpreter `
   
   ```
   private class PythonInterpreter(process: Process, gatewayServer: GatewayServer)
       extends ProcessInterpreter(process)
       with Logging {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org