[GitHub] [accumulo] ctubbsii commented on a change in pull request #1433: Standardize license headers

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1433: Standardize license headers
URL: https://github.com/apache/accumulo/pull/1433#discussion_r346925865
 
 

 ##########
 File path: test/src/main/java/org/apache/accumulo/test/ShellIT.java
 ##########
 @@ -400,7 +400,7 @@ public void execFileTest() throws IOException {
     Shell.log.debug("Starting exec file test --------------------------");
     shell.config("--config-file", config.toString(), "-u", "root", "-p", getRootPassword(), "-zi",
         getCluster().getInstanceName(), "-zh", getCluster().getZooKeepers(), "-f",
-        "src/main/resources/shellit.txt");
+        "src/main/resources/shellit.shellit");
 
 Review comment:
   Because the filename extension, `.txt` has a specific format for the license header, built-in to the plugin, and the choice was either rename this test file (which I did), or override the built-in rule for *ALL* `.txt` files, which I didn't think was a good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services