You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "SalikramPaudel (via GitHub)" <gi...@apache.org> on 2025/06/23 22:59:37 UTC
[PR] [WIP] Fix: Unclosed aiohttp ClientSession and TCPConnector in DatabricksRunNowOperator (deferrable=True) [airflow]
SalikramPaudel opened a new pull request, #52119:
URL: https://github.com/apache/airflow/pull/52119
Closes: #51910
### What this PR does
Fixes unclosed `aiohttp.ClientSession` and `TCPConnector` warnings when using `DatabricksRunNowOperator` with `deferrable=True` in Airflow 3.0.2 and Databricks Provider 7.4.0.
### Background
As described in #51910, the following errors appear during deferrable task execution:
```
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x...>
Unclosed connector
connector: <aiohttp.connector.TCPConnector object at 0x...>
```
These indicate improper async resource cleanup during trigger polling.
### Fix
- Ensures `aiohttp.ClientSession` and `TCPConnector` are properly closed
- Applies best practices for async resource lifecycle management in the trigger
### Status
- [x] Initial fix implemented
- [ ] Unit tests in progress
- [ ] Manual testing in progress
---
Opening as a **Draft PR** to allow early feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Fix: Unclosed aiohttp ClientSession and TCPConnector in DatabricksRunNowOperator (deferrable=True) [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #52119:
URL: https://github.com/apache/airflow/pull/52119#issuecomment-2998207867
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Fix: Unclosed aiohttp ClientSession and TCPConnector in DatabricksRunNowOperator (deferrable=True) [airflow]
Posted by "albertwangnz (via GitHub)" <gi...@apache.org>.
albertwangnz commented on PR #52119:
URL: https://github.com/apache/airflow/pull/52119#issuecomment-3001778882
Awesome, @SalikramPaudel. Thank you for the fix. Cannot wait for upgrading to this version :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org