You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/11 02:41:57 UTC
[GitHub] [flink] zhengcanbin opened a new pull request #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
zhengcanbin opened a new pull request #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054
## What is the purpose of the change
It's likely that one would pull images from the private image registries, credentials can be passed with the Pod specification through the `imagePullSecrets` parameter,
which refers to the k8s secret by name. Implementation wise we expose a new configuration option to the users and then pass it along to the K8S.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:MANUAL TriggerID:584488205
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148388347 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
* ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148388347) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on a change in pull request #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on a change in pull request #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#discussion_r378032034
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
##########
@@ -288,6 +290,21 @@ public static ResourceRequirements getResourceRequirements(int mem, double cpu)
.build();
}
+ /**
+ * Parses comma-separated list of imagePullSecrets into K8s-understandable format.
+ */
+ public static LocalObjectReference[] parseImagePullSecrets(@Nullable String imagePullSecrets) {
Review comment:
Good catch. Will try it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:MANUAL TriggerID:584488205
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11054: [FLINK-15652][K8s]
Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584457234
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 47f64cd0ddbb74874daff1607a30a999f4554ce1 (Tue Feb 11 02:44:28 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:MANUAL TriggerID:584488205
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148388347 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148388347 TriggerType:MANUAL TriggerID:584992416
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
* ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148388347) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11054: [FLINK-15652][K8s]
Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584537708
> It looks a bit weird that both travis and azure complain with
>
> ```
> 06:50:19.131 [ERROR] ConfigOptionsDocsCompletenessITCase.testCompleteness:75->compareDocumentedAndExistingOptions:179 Documentation is outdated, please regenerate it according to the instructions in flink-docs/README.md.
> Problems:
> Option kubernetes.container.image.pull-secretes in class org.apache.flink.kubernetes.configuration.KubernetesConfigOptions is not documented.
> Documented option kubernetes.container.image.pull-secrets does not exist.
> ```
>
> though I've seen the document updated. Could you please run maven command to re-generate configuration document to see if there are some string mismatch?
Thanks @TisonKun . Will try it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:MANUAL TriggerID:584488205
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148388347 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
* ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148388347) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11054: [FLINK-15652][K8s]
Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584488205
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
TisonKun commented on a change in pull request #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#discussion_r378020468
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
##########
@@ -288,6 +290,21 @@ public static ResourceRequirements getResourceRequirements(int mem, double cpu)
.build();
}
+ /**
+ * Parses comma-separated list of imagePullSecrets into K8s-understandable format.
+ */
+ public static LocalObjectReference[] parseImagePullSecrets(@Nullable String imagePullSecrets) {
Review comment:
IIRC the community introduce a list type config option. You can refer to `PipelineOptions.JARS` for an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun closed pull request #11054: [FLINK-15652][K8s]
Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
TisonKun closed pull request #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:MANUAL TriggerID:584488205
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148388347 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148388347 TriggerType:MANUAL TriggerID:584992416
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063 TriggerType:MANUAL TriggerID:584992416
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
* ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148388347) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11054: [FLINK-15652][K8s]
Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584457006
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #11054: [FLINK-15652][K8s]
Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584513302
It looks a bit weird that both travis and azure complain with
```
06:50:19.131 [ERROR] ConfigOptionsDocsCompletenessITCase.testCompleteness:75->compareDocumentedAndExistingOptions:179 Documentation is outdated, please regenerate it according to the instructions in flink-docs/README.md.
Problems:
Option kubernetes.container.image.pull-secretes in class org.apache.flink.kubernetes.configuration.KubernetesConfigOptions is not documented.
Documented option kubernetes.container.image.pull-secrets does not exist.
```
though I've seen the document updated. Could you please run maven command to re-generate configuration document to see if there are some string mismatch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhengcanbin commented on issue #11054: [FLINK-15652][K8s]
Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
zhengcanbin commented on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584992416
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11054: [FLINK-15652][K8s]
Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:MANUAL TriggerID:584488205
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:MANUAL TriggerID:584488205
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
* ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#issuecomment-584462322
<!--
Meta data
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:PUSH TriggerID:47f64cd0ddbb74874daff1607a30a999f4554ce1
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584457006
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148308767 TriggerType:MANUAL TriggerID:584488205
Hash:47f64cd0ddbb74874daff1607a30a999f4554ce1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037 TriggerType:MANUAL TriggerID:584488205
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148388347 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063 TriggerType:PUSH TriggerID:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148388347 TriggerType:MANUAL TriggerID:584992416
Hash:ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063 TriggerType:MANUAL TriggerID:584992416
-->
## CI report:
* 47f64cd0ddbb74874daff1607a30a999f4554ce1 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148308767) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5037)
* ef567558ddeeec7c9d36c972b9b5fad1d8fe0b12 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148388347) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5063)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services