You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2025/01/31 13:54:37 UTC
[PR] fix(DatePicker): Increase z-index over Modal [superset]
geido opened a new pull request, #32061:
URL: https://github.com/apache/superset/pull/32061
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Fixes the z-index of the DatePicker to be over Modal.
### BEFORE
<img width="1229" alt="Screenshot 2025-01-31 at 14 53 27" src="https://github.com/user-attachments/assets/0fab5826-34ea-427e-a3ee-0eb5e348ab02" />
### AFTER
<img width="1232" alt="Screenshot 2025-01-31 at 14 54 01" src="https://github.com/user-attachments/assets/553f89ca-4cde-493e-a6c2-1289862a3006" />
### TESTING INSTRUCTIONS
1. Open the DatePicker from within a Modal
2. The DatePicker should be above the Modal
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(DatePicker): Increase z-index over Modal [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #32061:
URL: https://github.com/apache/superset/pull/32061#issuecomment-2627553447
Test envs still failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(DatePicker): Increase z-index over Modal [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32061:
URL: https://github.com/apache/superset/pull/32061#issuecomment-2627514205
@geido Processing your ephemeral environment request [here](https://github.com/apache/superset/actions/runs/13074949961). Action: **up**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(DatePicker): Increase z-index over Modal [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido merged PR #32061:
URL: https://github.com/apache/superset/pull/32061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(DatePicker): Increase z-index over Modal [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on PR #32061:
URL: https://github.com/apache/superset/pull/32061#issuecomment-2627489123
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org