You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/03/09 13:21:30 UTC

[Bug 57678] New: [PATCH] Incorrect year parsing in message submission chunk

https://bz.apache.org/bugzilla/show_bug.cgi?id=57678

            Bug ID: 57678
           Summary: [PATCH] Incorrect year parsing in message submission
                    chunk
           Product: POI
           Version: 3.10-FINAL
          Hardware: PC
            Status: NEW
          Keywords: PatchAvailable
          Severity: normal
          Priority: P2
         Component: HSMF
          Assignee: dev@poi.apache.org
          Reporter: adrian.conlon@arup.com

Created attachment 32551
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32551&action=edit
Generated using "ant -f patch.xml"

Some messages sent before the year 2000 are being parsed (incorrectly!) as
having been sent in the future.

For the test case I'm interested in, some emails actually sent in the year 1999
are shown as having been sent in the year 2099.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57678] [PATCH] Incorrect year parsing in message submission chunk

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57678

--- Comment #3 from Adrian Conlon <ad...@arup.com> ---
The message submission chunk as extracted by POI HSMF appears to be:

PR_MESSAGE_SUBMISSION_ID/PidTagMessageSubmissionId

Documented here ([MS-OXOMSG] Section 2.2.1.79)
https://msdn.microsoft.com/en-us/library/hh369838(v=exchg.80).aspx

Effectively, it appears as though this property shouldn't be interpreted to
extract a date.  Perhaps the solution would be to ignore the message submission
chunk (at least in terms of date/time extraction).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57678] [PATCH] Incorrect year parsing in message submission chunk

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57678

Adrian Conlon <ad...@arup.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32551|0                           |1
        is obsolete|                            |
  Attachment #32552|0                           |1
        is obsolete|                            |

--- Comment #4 from Adrian Conlon <ad...@arup.com> ---
Created attachment 32590
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32590&action=edit
Updated patch for problem

Corrects a less/greater than mix up (sorry Nick, you were right to question
that one!).

Replaces one test case with three cases covering the transition around the
pivot year (1980).

Patch seems (to me) to be in a better format.

N.B.
The test cases are *manually* hacked using MFCMapi.  No emails I send (using
Outlook/Exchange) include the PR_MESSAGE_SUBMISSION_ID.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57678] [PATCH] Incorrect year parsing in message submission chunk

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57678

--- Comment #1 from Adrian Conlon <ad...@arup.com> ---
Created attachment 32552
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32552&action=edit
Generated using "ant -f patch.xml"

Second part of the patch, includes test data.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57678] [PATCH] Incorrect year parsing in message submission chunk

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57678

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Dominik Stadler <do...@gmx.at> ---
Applied via r1688993, hopefully this code will get revised before 2080 when
this would start to fail...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 57678] [PATCH] Incorrect year parsing in message submission chunk

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57678

Adrian Conlon <ad...@arup.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #2 from Adrian Conlon <ad...@arup.com> ---
I forgot to note: patch applies to "trunk".

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org