You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2019/07/10 08:19:28 UTC

[GitHub] [logging-log4j2] remkop commented on issue #291: [LOG4J2-2604/2649] Change MethodHandle to Constructor to adapt graalvm

remkop commented on issue #291: [LOG4J2-2604/2649] Change MethodHandle to Constructor to adapt graalvm
URL: https://github.com/apache/logging-log4j2/pull/291#issuecomment-509961300
 
 
   I don't disagree with these changes, but please do 2 things:
   * respect the spacing of the original file: space between `if` and `(`, space between `try` and `{`, etc.
   * Please add a comment to `ContextDataFactory.DEFAULT_CONSTRUCTOR` as to _why_ this should be a `Constructor` and not a `MethodHandle`. The comment may contain JIRA or GitHub issue numbers or links.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services