You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gyfora (via GitHub)" <gi...@apache.org> on 2023/05/16 07:19:32 UTC
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #601: [hotfix][docs] fix some typos
gyfora commented on code in PR #601:
URL: https://github.com/apache/flink-kubernetes-operator/pull/601#discussion_r1194722354
##########
docs/content/docs/custom-resource/autoscaler.md:
##########
@@ -55,20 +55,20 @@ To disable scaling actions, set: `kubernetes.operator.job.autoscaler.scaling.ena
Depending on your environment and job characteristics there are a few very important configurations that will affect how well the autoscaler works.
-Key configuration areas
- - Job and per operator max parallelism
+Key configuration areas:
+ - Job and per operator max-parallelism
- Stabilization and metrics collection intervals
- Target utilization and flexible boundaries
- Target catch-up duration and restart time
The defaults might work reasonably well for many applications, but some tuning may be required in this early stage of the autoscaler module.
-### Job and per operator max parallelism
+### Job and per operator max-parallelism
-When computing the scaled parallelism, the autoscaler always considers the max parallelism settings for each job vertex to ensure that it doesn't introduce unnecessary data skew.
-The computed parallelism will always be a divisor of the max_parallelism number.
+When computing the scaled parallelism, the autoscaler always considers the max-parallelism settings for each job vertex to ensure that it doesn't introduce unnecessary data skew.
+The computed parallelism will always be a divisor of the max-parallelism number.
-To ensure flexible scaling it is therefore recommended to chose max parallelism settings that have a [lot of divisors](https://en.wikipedia.org/wiki/Highly_composite_number) instead of relying on the Flink provided defaults.
+To ensure flexible scaling it is therefore recommended to chose max-parallelism settings that have a [lot of divisors](https://en.wikipedia.org/wiki/Highly_composite_number) instead of relying on the Flink provided defaults.
Review Comment:
Can you also fix : `chose` -> `choose`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org