You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mikebridge (via GitHub)" <gi...@apache.org> on 2026/10/20 16:48:59 UTC
[PR] test(reports): cover scheduled reports on semantic-view charts [superset]
mikebridge opened a new pull request, #45526:
URL: https://github.com/apache/superset/pull/45526
### SUMMARY
Scheduled reports on charts built on semantic views had no regression coverage. These tests pin CSV and TEXT content generation through the real chart-data API, plus PNG and PDF content generation at the mocked browser-capture boundary.
The tests reuse the report schedule, capture-context and image helpers, and share the existing semantic extension fixtures with the provider tests. They verify that report asset validation accepts a semantic-view chart even when its SQL-table relationship is empty.
The tests run with SQLite and the in-memory semantic provider. Authentication and datasource lookup are mocked, outbound report requests are routed to Flask's test client, and browser capture is mocked. No services, real browser or notification delivery are required. XLSX is excluded; its header defect is being addressed separately.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI change. Before, semantic-chart report formats had no dedicated tests. After, CSV/TEXT assert the filtered provider result and display labels; PNG/PDF assert the captured chart URL, executor, image content and PDF output.
### TESTING INSTRUCTIONS
```bash
TZ=UTC PYTHONPATH=.:superset-core/src pytest -q tests/unit_tests/commands/report/ tests/unit_tests/semantic_layers/
pre-commit run --files tests/unit_tests/commands/report/conftest.py tests/unit_tests/commands/report/semantic_view_report_test.py tests/unit_tests/semantic_layers/conftest.py tests/unit_tests/semantic_layers/e2e_stub_extension_test.py
```
Negative controls were restored after verification: rewriting the export datasource type made both CSV/TEXT cases fail, and changing the captured chart id made both PNG/PDF cases fail. These are content-generation tests; they do not certify live browser rendering or delivery.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Required feature flags: `SEMANTIC_LAYERS` (existing, enabled by the tests)
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(reports): cover scheduled reports on semantic-view charts [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45526:
URL: https://github.com/apache/superset/pull/45526#issuecomment-6296699260
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45526?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.61%. Comparing base ([`1df897b`](https://app.codecov.io/gh/apache/superset/commit/1df897b3bbae3b75dbd2e76c10af0ff2c4e70dcf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b399ff5`](https://app.codecov.io/gh/apache/superset/commit/b399ff52cbdedc2b70cb0e94a73e647f970ed466?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45526 +/- ##
==========================================
- Coverage 83.65% 83.61% -0.05%
==========================================
Files 3053 3053
Lines 200641 200647 +6
Branches 46820 46823 +3
==========================================
- Hits 167840 167761 -79
- Misses 29561 29627 +66
- Partials 3240 3259 +19
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45526/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/45526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.91% <ø> (-0.01%)` | :arrow_down: |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/45526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/45526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/45526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.66% <ø> (-0.01%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/45526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.10% <ø> (-0.08%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/45526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.64% <ø> (+<0.01%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/45526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.31% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45526?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(reports): cover scheduled reports on semantic-view charts [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi merged PR #45526:
URL: https://github.com/apache/superset/pull/45526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(reports): cover scheduled reports on semantic-view charts [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45526:
URL: https://github.com/apache/superset/pull/45526#issuecomment-6296260115
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | b399ff52cbdedc2b70cb0e94a73e647f970ed466 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ad79b79ff22da98e126226b |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45526--superset-docs-preview.netlify.app](https://deploy-preview-45526--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#Dco7DoAgDADQu3SWwQ4o3sBj8CmRRD6hjcYY7y7bG94LrdfcBDaACVy3xR_DQiyqU6tdWDFlWyR5dSW6ebRA7azPHkbUNizGLSZGxGDNSjNqRO3g-wE) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-45526--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] test(reports): cover scheduled reports on semantic-view charts [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45526:
URL: https://github.com/apache/superset/pull/45526#issuecomment-6297079207
## CodeAnt PR Risk: Low Risk
- The PR appears safe to merge; the visible changes add focused report tests and share an existing semantic stub fixture.
- The tests cover semantic-view CSV, text, image, and PDF reports, plus report asset validation.
**Assessed commit:** `b399ff52cbde`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org