[GitHub] [phoenix] joshelser commented on a change in pull request #874: PHOENIX-5860 Throw exception which region is closing or splitting when delete data

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #874:
URL: https://github.com/apache/phoenix/pull/874#discussion_r485821321



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -1430,4 +1430,17 @@ public InternalScanner run() throws Exception {
         }
         return s;
     }
+
+    /**
+     * roll back after split failed, will isRegionClosingOrSplitting set false,
+     * and then write region will is available
+     * @param ctx
+     * @throws IOException
+     */
+    @Override
+    public void preRollBackSplit(ObserverContext<RegionCoprocessorEnvironment> ctx) throws IOException {

Review comment:
       Do you want `preRollBackSplit` and not `postRollBackSplit`? If we're only about to rollback a split, I would say that, semantically, the region is still splitting until that operation is complete. postRollBackSplit seems more correct to me.
   
   Also want to note: this method is only relevant for HBase 1.x.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org