You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/20 16:15:54 UTC
[GitHub] [airflow] ashb opened a new pull request #8476: Remove duplicate error message on chart connection failure
ashb opened a new pull request #8476:
URL: https://github.com/apache/airflow/pull/8476
This caused the error message to be shown twice - once in the chart body
(which is faded out) and again at the "top-level" error
- [x] Description above provides context of the change
- [x] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-io edited a comment on issue #8476: Remove duplicate error message on chart connection failure
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8476:
URL: https://github.com/apache/airflow/pull/8476#issuecomment-617430065
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=h1) Report
> Merging [#8476](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/ab546386ea96cee82d006a7265fb1ba7a2a8708c&el=desc) will **decrease** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-test #8476 +/- ##
==============================================
- Coverage 81.86% 81.30% -0.56%
==============================================
Files 542 542
Lines 37221 37223 +2
==============================================
- Hits 30471 30265 -206
- Misses 6750 6958 +208
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.18%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `91.17% <0.00%> (-5.89%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `86.68% <0.00%> (-5.20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `75.34% <0.00%> (-5.12%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=footer). Last update [ab54638...f8a3f91](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-io edited a comment on issue #8476: Remove duplicate error message on chart connection failure
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8476:
URL: https://github.com/apache/airflow/pull/8476#issuecomment-617430065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-io commented on issue #8476: Remove duplicate error message on chart connection failure
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8476:
URL: https://github.com/apache/airflow/pull/8476#issuecomment-617430065
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=h1) Report
> Merging [#8476](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/ab546386ea96cee82d006a7265fb1ba7a2a8708c&el=desc) will **decrease** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-test #8476 +/- ##
==============================================
- Coverage 81.86% 81.30% -0.56%
==============================================
Files 542 542
Lines 37221 37223 +2
==============================================
- Hits 30471 30265 -206
- Misses 6750 6958 +208
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.18%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `91.17% <0.00%> (-5.89%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `86.68% <0.00%> (-5.20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `75.34% <0.00%> (-5.12%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=footer). Last update [ab54638...f8a3f91](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #8476: Remove duplicate error message on chart connection failure
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #8476:
URL: https://github.com/apache/airflow/pull/8476#discussion_r411510894
##########
File path: airflow/www/templates/airflow/nvd3.html
##########
@@ -160,9 +160,6 @@ <h4 class="panel-title">
url = "{{ url_for('airflow.chart_data') }}" + location.search;
$.getJSON(url, function(payload) {
$('#loading').hide();
- if (payload.error !== undefined) {
- $('#chart_body').html('<div class="alert alert-danger">' + payload.error + '</div>');
Review comment:
The error is still shown by the error function on L181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] codecov-io edited a comment on issue #8476: Remove duplicate error message on chart connection failure
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8476:
URL: https://github.com/apache/airflow/pull/8476#issuecomment-617430065
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=h1) Report
> Merging [#8476](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=desc) into [v1-10-test](https://codecov.io/gh/apache/airflow/commit/ab546386ea96cee82d006a7265fb1ba7a2a8708c&el=desc) will **decrease** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v1-10-test #8476 +/- ##
==============================================
- Coverage 81.86% 81.30% -0.56%
==============================================
Files 542 542
Lines 37221 37223 +2
==============================================
- Hits 30471 30265 -206
- Misses 6750 6958 +208
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `16.88% <0.00%> (-76.63%)` | :arrow_down: |
| [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...irflow/contrib/operators/redis\_publish\_operator.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9yZWRpc19wdWJsaXNoX29wZXJhdG9yLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/contrib/sensors/mongo\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvbW9uZ29fc2Vuc29yLnB5) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `47.79% <0.00%> (-41.18%)` | :arrow_down: |
| [airflow/contrib/sensors/redis\_key\_sensor.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvcmVkaXNfa2V5X3NlbnNvci5weQ==) | `61.53% <0.00%> (-38.47%)` | :arrow_down: |
| [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `91.17% <0.00%> (-5.89%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `86.68% <0.00%> (-5.20%)` | :arrow_down: |
| [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `75.34% <0.00%> (-5.12%)` | :arrow_down: |
| [airflow/contrib/hooks/mongo\_hook.py](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL21vbmdvX2hvb2sucHk=) | `93.15% <0.00%> (-4.11%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/8476/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=footer). Last update [ab54638...f8a3f91](https://codecov.io/gh/apache/airflow/pull/8476?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org