You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "tao12345666333 (via GitHub)" <gi...@apache.org> on 2023/05/08 08:22:09 UTC
[GitHub] [apisix] tao12345666333 opened a new issue, #9429: feat: add id to global_rules schema
tao12345666333 opened a new issue, #9429:
URL: https://github.com/apache/apisix/issues/9429
### Description
xref: https://github.com/apache/apisix/pull/8439
https://github.com/apache/apisix/blob/9ad740234dff97653d057350f3177be18ec7ddd9/apisix/schema_def.lua#L831-L840
the `id` is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tarunclub commented on issue #9429: feat: add id to global_rules schema
Posted by "tarunclub (via GitHub)" <gi...@apache.org>.
tarunclub commented on issue #9429:
URL: https://github.com/apache/apisix/issues/9429#issuecomment-1538245094
Hey,
Just wanted to let you all know that I've raised a pull request for issue #9432. It includes the changes we discussed earlier to add the 'id' property to the required section of the global_rule schema.
Please take a look and let me know if you have any feedback or concerns. Your review and feedback would be greatly appreciated.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tarunclub commented on issue #9429: feat: add id to global_rules schema
Posted by "tarunclub (via GitHub)" <gi...@apache.org>.
tarunclub commented on issue #9429:
URL: https://github.com/apache/apisix/issues/9429#issuecomment-1538220590
Hey, I think I can help you out with this can you assign this issue to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tao12345666333 commented on issue #9429: feat: add id to global_rules schema
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on issue #9429:
URL: https://github.com/apache/apisix/issues/9429#issuecomment-1543239354
thanks
https://github.com/apache/apisix/pull/8439#issuecomment-1334667221
please add test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tao12345666333 commented on issue #9429: feat: add id to global_rules schema
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on issue #9429:
URL: https://github.com/apache/apisix/issues/9429#issuecomment-1555897271
@tarunclub has opened a PR for this, but there has been no feedback and no test case added.
If you are willing to work on this, you can open a PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tao12345666333 closed issue #9429: feat: add id to global_rules schema
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 closed issue #9429: feat: add id to global_rules schema
URL: https://github.com/apache/apisix/issues/9429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] howiieyu commented on issue #9429: feat: add id to global_rules schema
Posted by "howiieyu (via GitHub)" <gi...@apache.org>.
howiieyu commented on issue #9429:
URL: https://github.com/apache/apisix/issues/9429#issuecomment-1556806579
@tao12345666333 I opened a PR for this issue, please check it for #9517 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] howiieyu commented on issue #9429: feat: add id to global_rules schema
Posted by "howiieyu (via GitHub)" <gi...@apache.org>.
howiieyu commented on issue #9429:
URL: https://github.com/apache/apisix/issues/9429#issuecomment-1555399456
I would like this issue to be assigned to me if possible, thanks.
@spacewander @tao12345666333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tao12345666333 commented on issue #9429: feat: add id to global_rules schema
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on issue #9429:
URL: https://github.com/apache/apisix/issues/9429#issuecomment-1577863463
#9517 has been merged, I will close this one, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org