You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 21:41:24 UTC
[GitHub] [airflow] kaxil opened a new pull request #10526: Remove unreachable code in test_user_command.py
kaxil opened a new pull request #10526:
URL: https://github.com/apache/airflow/pull/10526
`self.fail(` raises exception so it would never run `return None` command
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10526: Remove unreachable code in test_user_command.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10526:
URL: https://github.com/apache/airflow/pull/10526#discussion_r475912159
##########
File path: tests/cli/commands/test_user_command.py
##########
@@ -177,7 +177,6 @@ def find_by_username(username):
matches = [u for u in retrieved_users if u['username'] == username]
if not matches:
self.fail("Couldn't find user with username {}".format(username))
- return None
Review comment:
Ah no. This one is truly unreachable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10526: Remove unreachable code in test_user_command.py
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10526:
URL: https://github.com/apache/airflow/pull/10526
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10526: Remove unreachable code in test_user_command.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10526:
URL: https://github.com/apache/airflow/pull/10526#discussion_r475911788
##########
File path: tests/cli/commands/test_user_command.py
##########
@@ -177,7 +177,6 @@ def find_by_username(username):
matches = [u for u in retrieved_users if u['username'] == username]
if not matches:
self.fail("Couldn't find user with username {}".format(username))
- return None
Review comment:
I think it's reachable in fact. Simply IntelliJ thinks it's not (because of the "fail" name for some reason). But this is a "normal" method, so it needs # noqa so that IntelliJ's false positive is silenced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org