You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by " Kaige Liu (JIRA)" <ji...@apache.org> on 2018/01/03 02:28:00 UTC
[jira] [Updated] (KYLIN-3081) Ineffective null check in
CubeController#cuboidsExport
[ https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kaige Liu updated KYLIN-3081:
-----------------------------
Attachment: KYLIN-3081-fix-potential-npe.patch
Patch attached. [~Shaofengshi] [~lidong_sjtu] please help review. Thanks.
> Ineffective null check in CubeController#cuboidsExport
> ------------------------------------------------------
>
> Key: KYLIN-3081
> URL: https://issues.apache.org/jira/browse/KYLIN-3081
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Kaige Liu
> Priority: Minor
> Attachments: KYLIN-3081-fix-potential-npe.patch
>
>
> {code}
> if (cuboidList == null || cuboidList.isEmpty()) {
> logger.warn("Cannot get recommend cuboid list for cube " + cubeName);
> }
> if (cuboidList.size() < top) {
> logger.info("Only recommend " + cuboidList.size() + " cuboids less than topn " + top);
> }
> {code}
> cuboidList.size() may result in NPE because the null check above doesn't have effect.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)