You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2016/11/29 14:57:03 UTC
Review Request 54166: ALTAS-1193: UI : UI to create entities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54166/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, and Suma Shivaprasad.
Bugs: ATLAS-1193
https://issues.apache.org/jira/browse/ATLAS-1193
Repository: atlas
Description
-------
* New UI for create/edit entities of different types.
* New UI for create/edit entity is integrated with new v2 api.
Diffs
-----
3party-licenses/datetimepicker-LICENSE PRE-CREATION
dashboardv2/gruntfile.js a252f1d
dashboardv2/public/css/scss/form.scss e17b7bb
dashboardv2/public/css/scss/search.scss 24b2212
dashboardv2/public/css/scss/tag.scss fa194fa
dashboardv2/public/index.html 04edcee
dashboardv2/public/js/collection/VEntityList.js 75e6733
dashboardv2/public/js/collection/VSearchList.js bcdecd3
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js PRE-CREATION
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_444444_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_555555_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_777620_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_777777_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_cc0000_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_ffffff_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.css 76845f2
dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.js 8951532
dashboardv2/public/js/main.js 2b005a9
dashboardv2/public/js/models/VEntity.js cd84e9d
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html f34bcea
dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html db31046
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 4706ba3
dashboardv2/public/js/views/entity/CreateEntityLayoutView.js PRE-CREATION
dashboardv2/public/js/views/search/SearchLayoutView.js f2b8a38
dashboardv2/public/js/views/search/SearchResultLayoutView.js 2eca6a1
Diff: https://reviews.apache.org/r/54166/diff/
Testing
-------
* Created entities for all the entity type and also edited with edit UI.
* Verified with new api.
Thanks,
Kalyani Kashikar
Re: Review Request 54166: ALTAS-1193: UI : UI to create entities
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54166/#review159444
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Dec. 16, 2016, 1:16 p.m., Kalyani Kashikar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54166/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2016, 1:16 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1193
> https://issues.apache.org/jira/browse/ATLAS-1193
>
>
> Repository: atlas
>
>
> Description
> -------
>
> * New UI for create/edit entities of different types.
> * New UI for create/edit entity is integrated with new v2 api.
>
>
> Diffs
> -----
>
> dashboardv2/gruntfile.js a252f1d
> dashboardv2/public/css/scss/form.scss e17b7bb
> dashboardv2/public/css/scss/override.scss 2db5568
> dashboardv2/public/css/scss/search.scss 24b2212
> dashboardv2/public/css/scss/tag.scss fa194fa
> dashboardv2/public/index.html 04edcee
> dashboardv2/public/js/collection/VEntityList.js bfcbe99
> dashboardv2/public/js/collection/VSearchList.js 640be40
> dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js PRE-CREATION
> dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css PRE-CREATION
> dashboardv2/public/js/main.js 772d3d4
> dashboardv2/public/js/models/VEntity.js 4347b62
> dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html f34bcea
> dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html PRE-CREATION
> dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html db31046
> dashboardv2/public/js/utils/UrlLinks.js a5288be
> dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js b2d2c7b
> dashboardv2/public/js/views/entity/CreateEntityLayoutView.js PRE-CREATION
> dashboardv2/public/js/views/search/SearchLayoutView.js d652aa4
> dashboardv2/public/js/views/search/SearchResultLayoutView.js 0a37834
>
> Diff: https://reviews.apache.org/r/54166/diff/
>
>
> Testing
> -------
>
> * Created entities for all the entity type and also edited with edit UI.
> * Verified with new api.
>
>
> Thanks,
>
> Kalyani Kashikar
>
>
Re: Review Request 54166: ALTAS-1193: UI : UI to create entities
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54166/
-----------------------------------------------------------
(Updated Dec. 16, 2016, 1:16 p.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Suma Shivaprasad.
Changes
-------
I have updated the patch ATLAS-1193.7.patch with fix for the issue of list of values getting appended to map<string> datatype,To fix this issue I have provided textbox for editing map<string> dataType values.
Bugs: ATLAS-1193
https://issues.apache.org/jira/browse/ATLAS-1193
Repository: atlas
Description
-------
* New UI for create/edit entities of different types.
* New UI for create/edit entity is integrated with new v2 api.
Diffs (updated)
-----
dashboardv2/gruntfile.js a252f1d
dashboardv2/public/css/scss/form.scss e17b7bb
dashboardv2/public/css/scss/override.scss 2db5568
dashboardv2/public/css/scss/search.scss 24b2212
dashboardv2/public/css/scss/tag.scss fa194fa
dashboardv2/public/index.html 04edcee
dashboardv2/public/js/collection/VEntityList.js bfcbe99
dashboardv2/public/js/collection/VSearchList.js 640be40
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js PRE-CREATION
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css PRE-CREATION
dashboardv2/public/js/main.js 772d3d4
dashboardv2/public/js/models/VEntity.js 4347b62
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html f34bcea
dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html db31046
dashboardv2/public/js/utils/UrlLinks.js a5288be
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js b2d2c7b
dashboardv2/public/js/views/entity/CreateEntityLayoutView.js PRE-CREATION
dashboardv2/public/js/views/search/SearchLayoutView.js d652aa4
dashboardv2/public/js/views/search/SearchResultLayoutView.js 0a37834
Diff: https://reviews.apache.org/r/54166/diff/
Testing
-------
* Created entities for all the entity type and also edited with edit UI.
* Verified with new api.
Thanks,
Kalyani Kashikar
Re: Review Request 54166: ALTAS-1193: UI : UI to create entities
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54166/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 10 a.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Suma Shivaprasad.
Changes
-------
I have updated the patch ATLAS-1193.6.patch with fix for the issue of list of values getting appended to map<string> datatype dropdown.
Bugs: ATLAS-1193
https://issues.apache.org/jira/browse/ATLAS-1193
Repository: atlas
Description
-------
* New UI for create/edit entities of different types.
* New UI for create/edit entity is integrated with new v2 api.
Diffs (updated)
-----
dashboardv2/gruntfile.js a252f1d
dashboardv2/public/css/scss/form.scss e17b7bb
dashboardv2/public/css/scss/override.scss 2db5568
dashboardv2/public/css/scss/search.scss 24b2212
dashboardv2/public/css/scss/tag.scss fa194fa
dashboardv2/public/index.html 04edcee
dashboardv2/public/js/collection/VEntityList.js bfcbe99
dashboardv2/public/js/collection/VSearchList.js 640be40
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js PRE-CREATION
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css PRE-CREATION
dashboardv2/public/js/main.js 772d3d4
dashboardv2/public/js/models/VEntity.js 4347b62
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html f34bcea
dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html db31046
dashboardv2/public/js/utils/UrlLinks.js a5288be
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js b2d2c7b
dashboardv2/public/js/views/entity/CreateEntityLayoutView.js PRE-CREATION
dashboardv2/public/js/views/search/SearchLayoutView.js d652aa4
dashboardv2/public/js/views/search/SearchResultLayoutView.js 0a37834
Diff: https://reviews.apache.org/r/54166/diff/
Testing
-------
* Created entities for all the entity type and also edited with edit UI.
* Verified with new api.
Thanks,
Kalyani Kashikar
Re: Review Request 54166: ALTAS-1193: UI : UI to create entities
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54166/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 1:06 p.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Suma Shivaprasad.
Changes
-------
This patch is rebased and is dependent on ATLAS-1287.
Bugs: ATLAS-1193
https://issues.apache.org/jira/browse/ATLAS-1193
Repository: atlas
Description
-------
* New UI for create/edit entities of different types.
* New UI for create/edit entity is integrated with new v2 api.
Diffs (updated)
-----
dashboardv2/gruntfile.js a252f1d
dashboardv2/public/css/scss/form.scss e17b7bb
dashboardv2/public/css/scss/override.scss 2db5568
dashboardv2/public/css/scss/search.scss 24b2212
dashboardv2/public/css/scss/tag.scss fa194fa
dashboardv2/public/index.html 04edcee
dashboardv2/public/js/collection/VEntityList.js 75e6733
dashboardv2/public/js/collection/VSearchList.js bcdecd3
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js PRE-CREATION
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css PRE-CREATION
dashboardv2/public/js/main.js 2b005a9
dashboardv2/public/js/models/VEntity.js cd84e9d
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html f34bcea
dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html db31046
dashboardv2/public/js/utils/UrlLinks.js PRE-CREATION
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 4706ba3
dashboardv2/public/js/views/entity/CreateEntityLayoutView.js PRE-CREATION
dashboardv2/public/js/views/search/SearchLayoutView.js f2b8a38
dashboardv2/public/js/views/search/SearchResultLayoutView.js 2eca6a1
Diff: https://reviews.apache.org/r/54166/diff/
Testing
-------
* Created entities for all the entity type and also edited with edit UI.
* Verified with new api.
Thanks,
Kalyani Kashikar
Re: Review Request 54166: ALTAS-1193: UI : UI to create entities
Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54166/
-----------------------------------------------------------
(Updated Dec. 1, 2016, 2:06 p.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Suma Shivaprasad.
Changes
-------
Fix for the Madhan's comment.
Bugs: ATLAS-1193
https://issues.apache.org/jira/browse/ATLAS-1193
Repository: atlas
Description
-------
* New UI for create/edit entities of different types.
* New UI for create/edit entity is integrated with new v2 api.
Diffs (updated)
-----
3party-licenses/datetimepicker-LICENSE PRE-CREATION
dashboardv2/gruntfile.js a252f1d
dashboardv2/public/css/scss/form.scss e17b7bb
dashboardv2/public/css/scss/override.scss 2db5568
dashboardv2/public/css/scss/search.scss 24b2212
dashboardv2/public/css/scss/tag.scss fa194fa
dashboardv2/public/index.html 04edcee
dashboardv2/public/js/collection/VEntityList.js 75e6733
dashboardv2/public/js/collection/VSearchList.js bcdecd3
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js PRE-CREATION
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_444444_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_555555_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_777620_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_777777_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_cc0000_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_ffffff_256x240.png PRE-CREATION
dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.css 76845f2
dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.js 8951532
dashboardv2/public/js/main.js 2b005a9
dashboardv2/public/js/models/VEntity.js cd84e9d
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html f34bcea
dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html db31046
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 4706ba3
dashboardv2/public/js/views/entity/CreateEntityLayoutView.js PRE-CREATION
dashboardv2/public/js/views/search/SearchLayoutView.js f2b8a38
dashboardv2/public/js/views/search/SearchResultLayoutView.js 2eca6a1
Diff: https://reviews.apache.org/r/54166/diff/
Testing
-------
* Created entities for all the entity type and also edited with edit UI.
* Verified with new api.
Thanks,
Kalyani Kashikar
Re: Review Request 54166: ALTAS-1193: UI : UI to create entities
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54166/#review157450
-----------------------------------------------------------
- nice work with UI to create/edit entities
- for array type of attributes (like hive_table.aliases), editing an existing entity causes null value to be saved - perhaps because empty value is displayed in the UI though the entity has values (in the store). Please review and update to fix this issue.
- Madhan Neethiraj
On Nov. 29, 2016, 2:56 p.m., Kalyani Kashikar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54166/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 2:56 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1193
> https://issues.apache.org/jira/browse/ATLAS-1193
>
>
> Repository: atlas
>
>
> Description
> -------
>
> * New UI for create/edit entities of different types.
> * New UI for create/edit entity is integrated with new v2 api.
>
>
> Diffs
> -----
>
> 3party-licenses/datetimepicker-LICENSE PRE-CREATION
> dashboardv2/gruntfile.js a252f1d
> dashboardv2/public/css/scss/form.scss e17b7bb
> dashboardv2/public/css/scss/search.scss 24b2212
> dashboardv2/public/css/scss/tag.scss fa194fa
> dashboardv2/public/index.html 04edcee
> dashboardv2/public/js/collection/VEntityList.js 75e6733
> dashboardv2/public/js/collection/VSearchList.js bcdecd3
> dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js PRE-CREATION
> dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css PRE-CREATION
> dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_444444_256x240.png PRE-CREATION
> dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_555555_256x240.png PRE-CREATION
> dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_777620_256x240.png PRE-CREATION
> dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_777777_256x240.png PRE-CREATION
> dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_cc0000_256x240.png PRE-CREATION
> dashboardv2/public/js/external_lib/jquery-ui/images/ui-icons_ffffff_256x240.png PRE-CREATION
> dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.css 76845f2
> dashboardv2/public/js/external_lib/jquery-ui/jquery-ui.min.js 8951532
> dashboardv2/public/js/main.js 2b005a9
> dashboardv2/public/js/models/VEntity.js cd84e9d
> dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html f34bcea
> dashboardv2/public/js/templates/entity/CreateEntityLayoutView_tmpl.html PRE-CREATION
> dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html db31046
> dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 4706ba3
> dashboardv2/public/js/views/entity/CreateEntityLayoutView.js PRE-CREATION
> dashboardv2/public/js/views/search/SearchLayoutView.js f2b8a38
> dashboardv2/public/js/views/search/SearchResultLayoutView.js 2eca6a1
>
> Diff: https://reviews.apache.org/r/54166/diff/
>
>
> Testing
> -------
>
> * Created entities for all the entity type and also edited with edit UI.
> * Verified with new api.
>
>
> Thanks,
>
> Kalyani Kashikar
>
>