[jira] [Comment Edited] (OPENJPA-2377) Metamodel.managedType returns wrong result for Embeddable

["Azuo Lee (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13657006#comment-13657006 ] 

Azuo Lee edited comment on OPENJPA-2377 at 5/14/13 12:36 PM:
-------------------------------------------------------------

The patch works fine for my code. Thanks.

P.S. Should I resolve and close the issure right now, or it will be closed automatically (or by you?) after the patch is committed?
                
      was (Author: azuo_lee):
    The patch works fine for my code. Thanks.
                  
> Metamodel.managedType returns wrong result for Embeddable
> ---------------------------------------------------------
>
>                 Key: OPENJPA-2377
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2377
>             Project: OpenJPA
>          Issue Type: Bug
>            Reporter: Azuo Lee
>            Assignee: Albert Lee
>         Attachments: OPENJPA-2377.trunk.patch
>
>
> I use the following code to dynamically determine if a class is an embeddable:
> Class c = Class.forName(s);
> ManagedType type = metamodel.managedType(c);
> if (type.getPersistenceType() == Type.PersistenceType.EMBEDDABLE) {
>      logger.debug("" + c + " is an Embeddable.");
>      // do somthing with the embeddable
> }
> else if (type.getPersistenceType() == Type.PersistenceType.ENTITY) {
>      logger.debug("" + c + " is an Entity.");
>      // do somthing with the entity
> }
> but when I use this code for an Embeddable, I always get "xxx is an Entity" logged.
> After examining the source code, I found "MetamodelImpl.instantiate" method will always put embeddable to both "embeddables" and "entities" containers, but "MetamodelImpl.managedType" method will first search "entities" and then "embeddables" for a persistence class, thus, "Entity" type will be returned for a ACTUAL Embeddable class.
> Hope this can be fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira