You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Chris Geer <ch...@cxtsoftware.com> on 2012/06/27 01:20:46 UTC
Review Request: Enable access to OS Templates defined in template libraries
from client API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/
-----------------------------------------------------------
Review request for shindig.
Description
-------
OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. I create SHINDIG-1795 to address this. This patch will allow you to use one or the other from the client libraries but not both.
This addresses bug SHINDIG-1788.
https://issues.apache.org/jira/browse/SHINDIG-1788
Diffs
-----
/trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
/trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
/trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
Diff: https://reviews.apache.org/r/5600/diff/
Testing
-------
Created an example gadget and tested it in the samplecontainer runtime.
Thanks,
Chris Geer
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Chris Geer <ch...@cxtsoftware.com>.
> On June 27, 2012, 9:55 p.m., Ryan Baxter wrote:
> > /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml, line 7
> > <https://reviews.apache.org/r/5600/diff/1/?file=116678#file116678line7>
> >
> > Where is this library?
That file is already in the folder with this gadget. It is a template library used from another sample gadget that I was reusing so that I didn't have to duplicate all the code.
> On June 27, 2012, 9:55 p.m., Ryan Baxter wrote:
> > /trunk/features/src/main/javascript/features/opensocial-templates/template.js, line 95
> > <https://reviews.apache.org/r/5600/diff/1/?file=116680#file116680line95>
> >
> > When reading the code, if a param is optional it is good to denote that in the parameter name, such as opt_tag. Also I guess you can use the JS doc annotation suggested here http://code.google.com/p/jsdoc-toolkit/wiki/TagParam
I had the parameter in the JS docs as "tag (optional)". I went ahead and changed the param name to opt_tag and changes the JS docs to "[opt_tag]" as per the recommendation.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8670
-----------------------------------------------------------
On June 26, 2012, 11:21 p.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 11:21 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8670
-----------------------------------------------------------
I noticed in the JIRA you removed the patch...please keep the patch and the JIRA and make sure it is the most up to date patch. You also need to grant the ASF license so we can commit it for you.
/trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml
<https://reviews.apache.org/r/5600/#comment18332>
Where is this library?
/trunk/features/src/main/javascript/features/opensocial-templates/template.js
<https://reviews.apache.org/r/5600/#comment18331>
When reading the code, if a param is optional it is good to denote that in the parameter name, such as opt_tag. Also I guess you can use the JS doc annotation suggested here http://code.google.com/p/jsdoc-toolkit/wiki/TagParam
- Ryan Baxter
On June 26, 2012, 11:21 p.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 11:21 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8707
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On June 28, 2012, 1:01 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 1:01 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Chris Geer <ch...@cxtsoftware.com>.
> On June 28, 2012, 2:04 p.m., Dan Dumont wrote:
> > /trunk/features/src/main/javascript/features/opensocial-templates/template.js, line 91
> > <https://reviews.apache.org/r/5600/diff/2/?file=117031#file117031line91>
> >
> > Could you be more descriptive of the actual functionality of the method in the comments here. Since the tag is optional, what happens if you don't provide it?
> >
> > (I know what happens, but can you put it in the jsdoc?)
OBE - reverted this method
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8711
-----------------------------------------------------------
On June 28, 2012, 1:01 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 1:01 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8711
-----------------------------------------------------------
/trunk/features/src/main/javascript/features/opensocial-templates/template.js
<https://reviews.apache.org/r/5600/#comment18384>
Could you be more descriptive of the actual functionality of the method in the comments here. Since the tag is optional, what happens if you don't provide it?
(I know what happens, but can you put it in the jsdoc?)
- Dan Dumont
On June 28, 2012, 1:01 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 1:01 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8765
-----------------------------------------------------------
Ship it!
Committed revision 1355574. Thanks Chris.
Please close this review as committed.
- Henry Saputra
On June 29, 2012, 3:42 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 3:42 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8756
-----------------------------------------------------------
Ship it!
Better fix. Like!
+1
- Henry Saputra
On June 29, 2012, 3:42 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 29, 2012, 3:42 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Chris Geer <ch...@cxtsoftware.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/
-----------------------------------------------------------
(Updated June 29, 2012, 3:42 a.m.)
Review request for shindig.
Changes
-------
Reverted change to registerTemplate and just set the id of the template to the tag through the compile xml node method that already existed.
Description
-------
OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
This addresses bug SHINDIG-1788.
https://issues.apache.org/jira/browse/SHINDIG-1788
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
/trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
Diff: https://reviews.apache.org/r/5600/diff/
Testing
-------
Created an example gadget and tested it in the samplecontainer runtime.
Thanks,
Chris Geer
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Chris Geer <ch...@cxtsoftware.com>.
> On June 28, 2012, 2:07 p.m., Dan Dumont wrote:
> > /trunk/features/src/main/javascript/features/opensocial-templates/loader.js, line 234
> > <https://reviews.apache.org/r/5600/diff/2/?file=117030#file117030line234>
> >
> > Not sure why you wouldn't leave the original function as-is and just set template.id = tag in the above if statement, and call the original register function.
I'm taking a new approach.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8712
-----------------------------------------------------------
On June 28, 2012, 1:01 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 1:01 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8712
-----------------------------------------------------------
/trunk/features/src/main/javascript/features/opensocial-templates/loader.js
<https://reviews.apache.org/r/5600/#comment18385>
Not sure why you wouldn't leave the original function as-is and just set template.id = tag in the above if statement, and call the original register function.
- Dan Dumont
On June 28, 2012, 1:01 a.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 1:01 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Chris Geer <ch...@cxtsoftware.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/
-----------------------------------------------------------
(Updated June 28, 2012, 1:01 a.m.)
Review request for shindig.
Changes
-------
Updated patch based on Ryan's comments.
Description
-------
OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
This addresses bug SHINDIG-1788.
https://issues.apache.org/jira/browse/SHINDIG-1788
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
/trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
/trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
Diff: https://reviews.apache.org/r/5600/diff/
Testing
-------
Created an example gadget and tested it in the samplecontainer runtime.
Thanks,
Chris Geer
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Chris Geer <ch...@cxtsoftware.com>.
> On June 26, 2012, 11:25 p.m., Henry Saputra wrote:
> > Correct me if I am wrong, but the issue about templates defined in the module inline are no longer available to the client apis happen regardless of this patch right? I dont see how this patch affect the inline template.
Henry, you are correct, that issue exists regardless of this patch. This patch just makes it possible to access template library defined templates from the client API. I was just pointing it out so people didn't try and use both at the same time from client libraries.
- Chris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8645
-----------------------------------------------------------
On June 26, 2012, 11:21 p.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 11:21 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/#review8645
-----------------------------------------------------------
Correct me if I am wrong, but the issue about templates defined in the module inline are no longer available to the client apis happen regardless of this patch right? I dont see how this patch affect the inline template.
- Henry Saputra
On June 26, 2012, 11:21 p.m., Chris Geer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5600/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 11:21 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
>
> One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
>
>
> This addresses bug SHINDIG-1788.
> https://issues.apache.org/jira/browse/SHINDIG-1788
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
> /trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
> /trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
>
> Diff: https://reviews.apache.org/r/5600/diff/
>
>
> Testing
> -------
>
> Created an example gadget and tested it in the samplecontainer runtime.
>
>
> Thanks,
>
> Chris Geer
>
>
Re: Review Request: Enable access to OS Templates defined in template
libraries from client API
Posted by Chris Geer <ch...@cxtsoftware.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5600/
-----------------------------------------------------------
(Updated June 26, 2012, 11:21 p.m.)
Review request for shindig.
Changes
-------
Referenced a wrong JIRA item.
Description (updated)
-------
OS Templates that were defined in template libraries were not available from the client APIs because registration was failing. This patch registers them so they can be used.
One side effect is that due to some timing with onLoadHandlers and templates, if template libraries are used, templates defined in the module statically are no longer available to the client apis. This patch will allow you to use one or the other from the client libraries but not both.
This addresses bug SHINDIG-1788.
https://issues.apache.org/jira/browse/SHINDIG-1788
Diffs
-----
/trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml PRE-CREATION
/trunk/features/src/main/javascript/features/opensocial-templates/loader.js 1354233
/trunk/features/src/main/javascript/features/opensocial-templates/template.js 1354233
Diff: https://reviews.apache.org/r/5600/diff/
Testing
-------
Created an example gadget and tested it in the samplecontainer runtime.
Thanks,
Chris Geer