You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2014/04/14 19:57:09 UTC
svn commit: r1587263 - /subversion/trunk/subversion/svnserve/serve.c
Author: julianfoad
Date: Mon Apr 14 17:57:09 2014
New Revision: 1587263
URL: http://svn.apache.org/r1587263
Log:
* subversion/svnserve/serve.c
(lock_many, unlock_many): Tweak comments for clarity following r1584114.
Modified:
subversion/trunk/subversion/svnserve/serve.c
Modified: subversion/trunk/subversion/svnserve/serve.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnserve/serve.c?rev=1587263&r1=1587262&r2=1587263&view=diff
==============================================================================
--- subversion/trunk/subversion/svnserve/serve.c (original)
+++ subversion/trunk/subversion/svnserve/serve.c Mon Apr 14 17:57:09 2014
@@ -2780,7 +2780,7 @@ static svn_error_t *lock_many(svn_ra_svn
an error. */
SVN_ERR(must_have_access(conn, pool, b, svn_authz_write, NULL, TRUE));
- /* Loop through the lock requests. */
+ /* Parse the lock requests from PATH_REVS into TARGETS. */
for (i = 0; i < path_revs->nelts; ++i)
{
const char *path, *full_path;
@@ -2812,7 +2812,9 @@ static svn_error_t *lock_many(svn_ra_svn
SVN_ERR(log_command(b, conn, subpool, "%s",
svn_log__lock(targets, steal_lock, subpool)));
- /* From here on we need to make sure any errors in authz_results, or
+ /* Check authz.
+
+ Note: From here on we need to make sure any errors in authz_results, or
results, are cleared before returning from this function. */
for (hi = apr_hash_first(pool, targets); hi; hi = apr_hash_next(hi))
{
@@ -2842,7 +2844,7 @@ static svn_error_t *lock_many(svn_ra_svn
steal_lock, lock_many_cb, &lmb,
pool, subpool);
- /* The client expects results in the same order as paths were supplied. */
+ /* Return results in the same order as the paths were supplied. */
for (i = 0; i < path_revs->nelts; ++i)
{
const char *path, *full_path;
@@ -2957,7 +2959,7 @@ static svn_error_t *unlock_many(svn_ra_s
subpool = svn_pool_create(pool);
- /* Loop through the unlock requests. */
+ /* Parse the unlock requests from PATH_REVS into TARGETS. */
for (i = 0; i < unlock_tokens->nelts; i++)
{
svn_ra_svn_item_t *item = &APR_ARRAY_IDX(unlock_tokens, i,
@@ -2988,7 +2990,9 @@ static svn_error_t *unlock_many(svn_ra_s
SVN_ERR(log_command(b, conn, subpool, "%s",
svn_log__unlock(targets, break_lock, subpool)));
- /* From here on we need to make sure any errors in authz_results, or
+ /* Check authz.
+
+ Note: From here on we need to make sure any errors in authz_results, or
results, are cleared before returning from this function. */
for (hi = apr_hash_first(pool, targets); hi; hi = apr_hash_next(hi))
{