You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "Xiaoxiang Yu (Jira)" <ji...@apache.org> on 2020/10/10 04:21:00 UTC
[jira] [Commented] (KYLIN-4780) Refactor AbstractExecutable to
extract the notification relevant business logic into a single component
[ https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211551#comment-17211551 ]
Xiaoxiang Yu commented on KYLIN-4780:
-------------------------------------
Good suggestion, I think this need a refactor. There was some previous patch like KYLIN-4227, but I didn't merge it because it is not extensible and strong, hope you can have a better improvement .[~yanghua]
> Refactor AbstractExecutable to extract the notification relevant business logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube. However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a notification listener, but only support mail service, it does not belong there;
> * The current implementation is hard to scale to other notification e.g. Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)