Re: [PR] feat: allow closing a curve on polar line series [echarts]

["yassilah (via GitHub)" <gi...@apache.org>]

yassilah commented on PR #17720:
URL: https://github.com/apache/echarts/pull/17720#issuecomment-1814115609

   Hi! So I got rid of the loop implementation for ECPolyline, which will use the ECPolygon `buildPath` method when `loop: true` instead. I tried to get rid of the `getPoints` function entirely and instead implement the logic in `drawSegment` directly to avoid unnecessary array manipulation but I actually can't because I still need it to work when `smooth: true`. So, instead I added a check to see whether the extra before/after points were necessary (when both loop and smooth are truthy), which should only trigger array manipulation when visually necessary. Hope that makes sense!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org