You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openwhisk.apache.org by ma...@apache.org on 2018/07/24 09:26:10 UTC

[incubator-openwhisk] branch master updated: Adjust offset topic replication factor seperately. (#3735)

This is an automated email from the ASF dual-hosted git repository.

markusthoemmes pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-openwhisk.git


The following commit(s) were added to refs/heads/master by this push:
     new 70c61d5  Adjust offset topic replication factor seperately. (#3735)
70c61d5 is described below

commit 70c61d5a64be4abc967cbf7d95101670a9182fac
Author: ningyougang <41...@qq.com>
AuthorDate: Tue Jul 24 17:26:07 2018 +0800

    Adjust offset topic replication factor seperately. (#3735)
    
    Currently, default.replication.factor and offsets.topic.replication.factor
    also uses kafka.replicationFactor, so it is better to separate them to use
    different ansbile vars.
---
 ansible/group_vars/all               | 1 +
 ansible/roles/kafka/tasks/deploy.yml | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/ansible/group_vars/all b/ansible/group_vars/all
index 9ce361e..5e59411 100644
--- a/ansible/group_vars/all
+++ b/ansible/group_vars/all
@@ -141,6 +141,7 @@ kafka:
     port: 8093
   heap: "{{ kafka_heap | default('1g') }}"
   replicationFactor: "{{ kafka_replicationFactor | default((groups['kafkas']|length)|int) }}"
+  offsetsTopicReplicationFactor: "{{ kafka_offsetsTopicReplicationFactor | default(kafka_replicationFactor) | default((groups['kafkas']|length)|int) }}"
   # adapt this param for production deployments depending on the number of kafka consumers
   networkThreads: "{{ kafka_network_threads | default(3) }}"
 
diff --git a/ansible/roles/kafka/tasks/deploy.yml b/ansible/roles/kafka/tasks/deploy.yml
index 436fcc9..b758c76 100644
--- a/ansible/roles/kafka/tasks/deploy.yml
+++ b/ansible/roles/kafka/tasks/deploy.yml
@@ -22,7 +22,7 @@
       "KAFKA_BROKER_ID": "{{ groups['kafkas'].index(inventory_hostname) }}"
       "KAFKA_HEAP_OPTS": "-Xmx{{ kafka.heap }} -Xms{{ kafka.heap }}"
       "KAFKA_ZOOKEEPER_CONNECT": "{{ zookeeper_connect_string }}"
-      "KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR": "{{ kafka.replicationFactor }}"
+      "KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR": "{{ kafka.offsetsTopicReplicationFactor }}"
       "KAFKA_AUTO_CREATE_TOPICS_ENABLE": "false"
       "KAFKA_NUM_NETWORK_THREADS": "{{ kafka.networkThreads }}"