[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#discussion_r602917794



##########
File path: build.gradle
##########
@@ -1423,18 +1423,8 @@ project(':streams') {
   dependencies {
     api project(':clients')
 
-    // use `api` dependency for `connect-json` for compatibility (e.g. users who use `JsonSerializer`/`JsonDeserializer`
-    // at compile-time without an explicit dependency on `connect-json`)
-    // this dependency should be removed after we unify data API
-    api(project(':connect:json')) {
-      // this transitive dependency is not used in Streams, and it breaks SBT builds
-      exclude module: 'javax.ws.rs-api'
-    }
-    
-    // `org.rocksdb.Options` is part of Kafka Streams public api via `RocksDBConfigSetter`
-    api libs.rocksDBJni
-    
     implementation libs.slf4jApi
+    implementation libs.rocksDBJni

Review comment:
       This seems wrong, is it unintentional?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org