You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "Pierre Smits (Jira)" <ji...@apache.org> on 2020/03/18 09:54:00 UTC

[jira] [Commented] (OFBIZ-10953) have CurrencyDimension have a dimensionId that is based on the natural key

    [ https://issues.apache.org/jira/browse/OFBIZ-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061573#comment-17061573 ] 

Pierre Smits commented on OFBIZ-10953:
--------------------------------------

Patch available via https://github.com/apache/ofbiz-plugins/pull/11 See OFBIZ-11414

> have CurrencyDimension have a dimensionId that is based on the natural key
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-10953
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10953
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: bi
>    Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>              Labels: CurrencyDimension, birt, currency, dimension, dwh
>         Attachments: 20200208_094840.jpg
>
>
> Currently the record sequencer (delegator.getNextSeqId) is used to determine the dimensionId for the CurrencyDimension. This is unnecessary as the uomId from the UOM table can be used for currency.
> It also makes it easier to set the foreign-key in fact tables by generating it based on the date provided, than by retrieving the dimensionId based on a retrieval through the getDimensionIdFromNaturalKey service.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)