You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/23 11:41:59 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #665: ORC-770: Support ZSTD in Avro data benchmark

dongjoon-hyun opened a new pull request #665:
URL: https://github.com/apache/orc/pull/665


   ### What changes were proposed in this pull request?
   
   This is WIP because this depends on #664 . I'll update this PR after #664 is merged.
   
   Apache Avro added ZSTD support. This PR aims to upgrade Apache Avro to 1.10.2 in benchmark.
   
   ### Why are the changes needed?
   
   To support ZSTD comparison in benchmark.
   
   ### How was this patch tested?
   
   ```
   $ git clean -fdx          
   $ cd java/bench
   $ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data -d sales -c zstd -f avro
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #665: ORC-770: Support ZSTD in Avro data benchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #665:
URL: https://github.com/apache/orc/pull/665#issuecomment-804907406


   Thank you, @pgaref !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #665: ORC-770: Support ZSTD in Avro data benchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #665:
URL: https://github.com/apache/orc/pull/665#issuecomment-804900287


   Yes, it's removed at the latest Apache Avro.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] pgaref merged pull request #665: ORC-770: Support ZSTD in Avro data benchmark

Posted by GitBox <gi...@apache.org>.
pgaref merged pull request #665:
URL: https://github.com/apache/orc/pull/665


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #665: ORC-770: Support ZSTD in Avro data benchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #665:
URL: https://github.com/apache/orc/pull/665#issuecomment-817446193


   I backported to this to branch-1.6 for next release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] pgaref commented on pull request #665: ORC-770: Support ZSTD in Avro data benchmark

Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #665:
URL: https://github.com/apache/orc/pull/665#issuecomment-804905379


   Thanks @dongjoon-hyun  just merged this! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #665: ORC-770: Support ZSTD in Avro data benchmark

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #665:
URL: https://github.com/apache/orc/pull/665#issuecomment-804890542


   This is ready for review, too.
   cc @pgaref 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org