You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/09/25 22:21:43 UTC
[kudu-CR] [DOCS] Added a version notice for changing kudu table names in Impala
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11515
Change subject: [DOCS] Added a version notice for changing kudu table names in Impala
......................................................................
[DOCS] Added a version notice for changing kudu table names in Impala
With IMPALA-5654, users cannot change kudu.table_name in IMPALA.
Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
---
M docs/kudu_impala_integration.adoc
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/11515/1
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[kudu-CR] ][DOCS] Added a version notice for changing managed Kudu table names in Impala
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 )
Change subject: ][DOCS] Added a version notice for changing managed Kudu table names in Impala
......................................................................
Patch Set 2:
(2 comments)
> (4 comments)
Thank you for the fix! I think it's just a couple of nits to correct and it's good to go.
http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG@7
PS2, Line 7: ]
nit: an extra closing brace; please remove it
http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG@9
PS2, Line 9: With IMPALA-5654, users cannot change kudu.table_name in IMPALA for
: managed Kudu tables created in Impala.
It looks like nitpicking, but this sentence contains mention of Impala twice, first as 'IMPALA' and then as 'Impala' (I don't count the reference to Impala JIRA ticket).
How about:
With IMPALA-5654, users can no longer change kudu.table_name property for managed Kudu tables in Impala.
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 18:58:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Added a version notice for changing managed Kudu table names in Impala
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11515
to look at the new patch set (#3).
Change subject: [DOCS] Added a version notice for changing managed Kudu table names in Impala
......................................................................
[DOCS] Added a version notice for changing managed Kudu table names in Impala
With IMPALA-5654, users can no longer change kudu.table_name property
for managed Kudu tables in Impala.
Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
---
M docs/kudu_impala_integration.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/11515/3
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [DOCS] Added a version notice for changing kudu table names in Impala
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 )
Change subject: [DOCS] Added a version notice for changing kudu table names in Impala
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG@9
PS1, Line 9: With IMPALA-5654, users cannot change kudu.table_name in IMPALA.
I think this is too generic and incorrect: for external tables, they still can do that even with IMPALA-5654.
IMPALA-5654 affects only internal (a.k.a. managed) tables.
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@687
PS1, Line 687: if the table is an internal table
The enclosed section is named
'Rename the underlying Kudu table for an internal table'
So, I don't think this extra is needed here.
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697
PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under
: Impala, it is possible to re-map an external table to point to a different Kudu
: table name.
I think this became confusing. What's the extra 'In Impala 2.11 and lower ...' is supposed to mean? That it's impossible to re-map an external table to a different Kudu table or that another application is not able to rename a Kudu table under Impala?
As I understand, even in Impala 2.12 and newer it's still possible to re-map an external table to point to a different Kudu table name, i.e. IMPALA-5654 is about internal or managed tables only.
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 00:41:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] ][DOCS] Added a version notice for changing managed Kudu table names in Impala
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11515
to look at the new patch set (#2).
Change subject: ][DOCS] Added a version notice for changing managed Kudu table names in Impala
......................................................................
][DOCS] Added a version notice for changing managed Kudu table names in Impala
With IMPALA-5654, users cannot change kudu.table_name in IMPALA for
managed Kudu tables created in Impala.
Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
---
M docs/kudu_impala_integration.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/11515/2
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [DOCS] Added a version notice for changing managed Kudu table names in Impala
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 )
Change subject: [DOCS] Added a version notice for changing managed Kudu table names in Impala
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG@7
PS2, Line 7: ]
> nit: an extra closing brace; please remove it
Done
http://gerrit.cloudera.org:8080/#/c/11515/2//COMMIT_MSG@9
PS2, Line 9: With IMPALA-5654, users cannot change kudu.table_name in IMPALA for
: managed Kudu tables created in Impala.
> It looks like nitpicking, but this sentence contains mention of Impala twic
Done
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 21:08:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Added a version notice for changing managed Kudu table names in Impala
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 )
Change subject: [DOCS] Added a version notice for changing managed Kudu table names in Impala
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 21:13:04 +0000
Gerrit-HasComments: No
[kudu-CR] ][DOCS] Added a version notice for changing managed Kudu table names in Impala
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 )
Change subject: ][DOCS] Added a version notice for changing managed Kudu table names in Impala
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11515/1//COMMIT_MSG@9
PS1, Line 9: With IMPALA-5654, users cannot change kudu.table_name in IMPALA.
> I think this is too generic and incorrect: for external tables, they still
Done
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@687
PS1, Line 687: if the table is an internal table
> The enclosed section is named
Done
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697
PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under
: Impala, it is possible to re-map an external table to point to a different Kudu
: table name.
> I meant: ... That it's impossible to re-map an external table to a differe
Version note removed
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697
PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under
: Impala, it is possible to re-map an external table to point to a different Kudu
: table name.
> I think this became confusing. What's the extra 'In Impala 2.11 and lower
Done
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 00:59:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Added a version notice for changing kudu table names in Impala
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11515 )
Change subject: [DOCS] Added a version notice for changing kudu table names in Impala
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc
File docs/kudu_impala_integration.adoc:
http://gerrit.cloudera.org:8080/#/c/11515/1/docs/kudu_impala_integration.adoc@697
PS1, Line 697: In Impala 2.11 and lower, if another application has renamed a Kudu table under
: Impala, it is possible to re-map an external table to point to a different Kudu
: table name.
> I think this became confusing. What's the extra 'In Impala 2.11 and lower
I meant: ... That it's impossible to re-map an external table to a different Kudu table or that another application is not able to rename a Kudu table under Impala starting with Impala version 2.12?
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 00:43:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [DOCS] Added a version notice for changing managed Kudu table names in Impala
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11515 )
Change subject: [DOCS] Added a version notice for changing managed Kudu table names in Impala
......................................................................
[DOCS] Added a version notice for changing managed Kudu table names in Impala
With IMPALA-5654, users can no longer change kudu.table_name property
for managed Kudu tables in Impala.
Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Reviewed-on: http://gerrit.cloudera.org:8080/11515
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M docs/kudu_impala_integration.adoc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If26f103d931dd7ed57b56cf34b0010d14c098928
Gerrit-Change-Number: 11515
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>