You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "marin-ma (via GitHub)" <gi...@apache.org> on 2025/10/23 12:24:31 UTC
[PR] [VL] Fix setup scripts with multiple commands to run [incubator-gluten]
marin-ma opened a new pull request, #10930:
URL: https://github.com/apache/incubator-gluten/pull/10930
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Fix setup scripts with multiple commands to run [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10930:
URL: https://github.com/apache/incubator-gluten/pull/10930#discussion_r2459422653
##########
dev/builddeps-veloxbe.sh:
##########
@@ -298,17 +298,17 @@ function setup_dependencies {
OS=`uname -s`
ARCH=`uname -m`
-commands_to_run=${OTHER_ARGUMENTS:-}
+commands_to_run=(${OTHER_ARGUMENTS[@]:-})
(
- if [[ "x$commands_to_run" == "x" ]]; then
+ if [[ ${#commands_to_run[@]} -eq 0 ]]; then
get_velox
if [ -z "${GLUTEN_VCPKG_ENABLED:-}" ] && [ $RUN_SETUP_SCRIPT == "ON" ]; then
setup_dependencies
fi
build_velox_backend
else
- echo "Commands to run: $commands_to_run"
- for cmd in "$commands_to_run"; do
Review Comment:
It seems we can also fix it by removing the quote mark as follows:
`for cmd in $commands_to_run; do`
They are both good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Fix setup scripts with multiple commands to run [incubator-gluten]
Posted by "marin-ma (via GitHub)" <gi...@apache.org>.
marin-ma merged PR #10930:
URL: https://github.com/apache/incubator-gluten/pull/10930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org