You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/12/13 15:10:41 UTC
Review Request 64576: Refactored if statements to use
containerClass().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64576/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Simplifies the conditional statements in mesos/containerizer.cpp to use
the function MesosContainerizerProcess::Container::containerClass().
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365
Diff: https://reviews.apache.org/r/64576/diff/1/
Testing
-------
```
GTEST_FILTER="" nice make check -j16 V=0
```
Thanks,
Armand Grillet
Re: Review Request 64576: Refactored if statements to use
containerClass().
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64576/#review193694
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64575', '63953', '64576']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64576
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64576/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2433 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2457 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2502 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2525 ms total)
[----------] Global test environment tear-down
[==========] 829 tests from 84 test cases ran. (329301 ms total)
[ PASSED ] 819 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] SlaveTest.ResourceProviderPublishAll
10 FAILED TESTS
YOU HAVE 201 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64576/logs/mesos-tests-stderr.log):
```
I1213 16:41:59.124222 4224 master.cpp:10158] Updating the state of task ce301ab5-48b0-4035-a18a-048a50dd4ce2 of framework b2cd12c8-b1f4-4530-9b57-87054dd62c41-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1213 16:41:59.124222 9764 slave.cpp:3400] Shutting down framework b2cd12c8-b1f4-4530-9b57-87054dd62c41-0000
I1213 16:41:59.125216 9764 slave.cpp:6114] Shutting down execuI1213 16:41:58.429234 9916 exec.cpp:162] Version: 1.5.0
I1213 16:41:58.452261 7864 exec.cpp:237] Executor registered on agent b2cd12c8-b1f4-4530-9b57-87054dd62c41-S0
I1213 16:41:58.455272 1728 executor.cpp:171] Received SUBSCRIBED event
I1213 16:41:58.460255 1728 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1213 16:41:58.460255 1728 executor.cpp:171] Received LAUNCH event
I1213 16:41:58.464264 1728 executor.cpp:637] Starting task ce301ab5-48b0-4035-a18a-048a50dd4ce2
I1213 16:41:58.540254 1728 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1213 16:41:59.098238 1728 executor.cpp:650] Forked command at 3136
I1213 16:41:59.126216 2584 exec.cpp:435] Executor asked to shutdown
I1213 16:41:59.127216 1728 executor.cpp:171] Received SHUTDOWN event
I1213 16:41:59.127216 1728 executor.cpp:747] Shutting down
I1213 16:41:59.127216 1728 executor.cpp:854] Sending SIGTERM to process tree at pid 3tor 'ce301ab5-48b0-4035-a18a-048a50dd4ce2' of framework b2cd12c8-b1f4-4530-9b57-87054dd62c41-0000 at executor(1)@10.3.1.11:51958
I1213 16:41:59.126216 9764 slave.cpp:909] Agent terminating
W1213 16:41:59.126216 9764 slave.cpp:3396] Ignoring shutdown framework b2cd12c8-b1f4-4530-9b57-87054dd62c41-0000 because it is terminating
I1213 16:41:59.126216 4224 master.cpp:10264] Removing task ce301ab5-48b0-4035-a18a-048a50dd4ce2 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework b2cd12c8-b1f4-4530-9b57-87054dd62c41-0000 on agent b2cd12c8-b1f4-4530-9b57-87054dd62c41-S0 at slave(326)@10.3.1.11:51937 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 16:41:59.129215 4224 master.cpp:1305] Agent b2cd12c8-b1f4-4530-9b57-87054dd62c41-S0 at slave(326)@10.3.1.11:51937 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1213 16:41:59.129215 4224 master.cpp:3364] Disconnecting agent b2cd12c8-b1f4-4530-9b57-87054dd62c41-S0 at slave(326)@10.3.1.11:51937 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 16:41:59.129215 5888 containerizer.cpp:2337] Destroying container 2f1944cb-2faf-40cb-86f5-2441a8ed22d4 in RUNNING state
I1213 16:41:59.130218 5888 containerizer.cpp:2952] Transitioning the state of container 2f1944cb-2faf-40cb-86f5-2441a8ed22d4 from RUNNING to DESTROYING
I1213 16:41:59.130218 4224 master.cpp:3383] Deactivating agent b2cd12c8-b1f4-4530-9b57-87054dd62c41-S0 at slave(326)@10.3.1.11:51937 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 16:41:59.130218 3876 hierarchical.cpp:344] Removed framework b2cd12c8-b1f4-4530-9b57-87054dd62c41-0000
I1213 16:41:59.130218 3876 hierarchical.cpp:766] Agent b2cd12c8-b1f4-4530-9b57-87054dd62c41-S0 deactivated
I1213 16:41:59.130218 5888 launcher.cpp:156] Asked to destroy container 2f1944cb-2faf-40cb-86f5-2441a8ed22d4
I1213 16:41:59.218348 8912 containerizer.cpp:2790] Container 2f1944cb-2faf-40cb-86f5-2441a8ed22d4 has exited
I1213 16:41:59.248680 4300 master.cpp:1147] Master terminating
I1213 16:41:59.250679 7852 hierarchical.cpp:609] Removed agent b2cd12c8-b1f4-4530-9b57-87054dd62c41-S0
I1213 16:41:59.592671 5272 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 13, 2017, 3:10 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64576/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 3:10 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-7361
> https://issues.apache.org/jira/browse/MESOS-7361
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Simplifies the conditional statements in mesos/containerizer.cpp to use
> the function MesosContainerizerProcess::Container::containerClass().
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 7ab0b07f689f872573ca458ae47cd6426ebc0365
>
>
> Diff: https://reviews.apache.org/r/64576/diff/1/
>
>
> Testing
> -------
>
> ```
> GTEST_FILTER="" nice make check -j16 V=0
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>