You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/02/28 17:31:24 UTC
[GitHub] [spark] hvanhovell commented on a diff in pull request #40222: [SPARK-42615][CONNECT][FOLLOW-UP] Implement correct version API in SparkSession for Scala client
hvanhovell commented on code in PR #40222:
URL: https://github.com/apache/spark/pull/40222#discussion_r1120489974
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -63,7 +62,9 @@ class SparkSession(
private[this] val allocator = new RootAllocator()
- def version: String = SPARK_VERSION
+ def version: String = {
Review Comment:
Make it a lazy val?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org