You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Tim Armstrong (JIRA)" <ji...@apache.org> on 2017/04/18 15:56:42 UTC

[jira] [Resolved] (IMPALA-5124) Fix BufferPool handling of scratch read errors

     [ https://issues.apache.org/jira/browse/IMPALA-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong resolved IMPALA-5124.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.9.0



IMPALA-5124: add tests for scratch read errors

Adds tests for read errors from permissions (i.e. open() fails),
corrupt data (integrity check fails) and truncated files (read() fails).

Fixes a couple of bugs:
* Truncated reads were not detected in TmpFilemgr
* IoMgr buffers weren't returned on error paths (this isn't a true leak
  but results in DCHECKs being hit).

Change-Id: I3f2b93588dd47f70a4863ecad3b5556c3634ccb4
Reviewed-on: http://gerrit.cloudera.org:8080/6562
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---

> Fix BufferPool handling of scratch read errors
> ----------------------------------------------
>
>                 Key: IMPALA-5124
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5124
>             Project: IMPALA
>          Issue Type: Sub-task
>          Components: Backend
>    Affects Versions: Impala 2.9.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>             Fix For: Impala 2.9.0
>
>
> We are missing test coverage of the BufferPool error path where the integrity check of on-disk data fails. We should add a backend test that injects read errors of the following kinds:
> * Truncated files
> * Corrupted files
> * Inaccessible/removed files
> I wrote a prototype of the tests and confirmed that there are some bugs in this area.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)