You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/28 06:45:14 UTC

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #588: [IOTDB-323] Batch insert in session

qiaojialin commented on a change in pull request #588:  [IOTDB-323] Batch insert in session
URL: https://github.com/apache/incubator-iotdb/pull/588#discussion_r351612750
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -1174,6 +1174,35 @@ public TSExecuteStatementResp insert(TSInsertionReq req) {
     }
   }
 
+  @Override
+  public TSStatus insertRowInBatch(TSInsertInBatchReq req) {
+    if (!checkLogin()) {
+      logger.info(INFO_NOT_LOGIN, IoTDBConstant.GLOBAL_DB_NAME);
+      return new TSStatus(getStatus(TSStatusCode.NOT_LOGIN_ERROR));
+    }
+
+    TSStatus status = null;
+    for (int i = 0; i < req.deviceIds.size(); i++) {
+      InsertPlan plan = new InsertPlan();
 
 Review comment:
   we can reuse this object

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services