[GitHub] [incubator-doris] morningman commented on a diff in pull request #8908: [fix](load) start transaction before we need it (#8819)

[GitBox <gi...@apache.org>]

morningman commented on code in PR #8908:
URL: https://github.com/apache/incubator-doris/pull/8908#discussion_r845320176


##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/SparkLoadPendingTask.java:
##########
@@ -145,6 +142,13 @@ private void createEtlJobConf() throws LoadException {
             throw new LoadException(e.getMessage());
         }
 
+        try {
+            ((SparkLoadJob) callback).beginTxn();
+        } catch (UserException e) {
+            LOG.error("failed to begin transaction", e);

Review Comment:
   ```suggestion
               LOG.warn("failed to begin transaction for spark load job {}", this.loadJobId, e);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org