[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4734: Enhance the exception handling in TableRebalancer

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4734: Enhance the exception handling in TableRebalancer
URL: https://github.com/apache/incubator-pinot/pull/4734#discussion_r337681950
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java
 ##########
 @@ -98,8 +98,15 @@ public RebalanceResult rebalance(TableConfig tableConfig, Configuration rebalanc
     }
 
     // Check that table exists and is enabled
-    IdealState currentIdealState =
-        _helixDataAccessor.getProperty(_helixDataAccessor.keyBuilder().idealStates(tableNameWithType));
+    IdealState currentIdealState;
+    try {
+      currentIdealState =
+          _helixDataAccessor.getProperty(_helixDataAccessor.keyBuilder().idealStates(tableNameWithType));
+    } catch (Exception e) {
+      LOGGER.warn("Caught exception while fetching IdealState for table: {}", tableNameWithType, e);
 
 Review comment:
   These exceptions are unusual system exception instead of invalid operator action (ZK exception instead of table does not exist). Also, real-time segment relocation is also done by TableRebalancer, so I would not treat it as a user facing tool. Same for other WARNING. For invalid operator action such as table does not exist/rebalance HLC table, no warning is logged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org