You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ye...@apache.org on 2010/08/06 11:03:33 UTC
svn commit: r982911 -
/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java
Author: yegor
Date: Fri Aug 6 09:03:32 2010
New Revision: 982911
URL: http://svn.apache.org/viewvc?rev=982911&view=rev
Log:
close OPC package before assertion, otherwise the test fails on Win7 (unix-based systems always pass)
Modified:
poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java?rev=982911&r1=982910&r2=982911&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java Fri Aug 6 09:03:32 2010
@@ -470,7 +470,8 @@ public final class TestPackage extends T
p.save(tempFile);
fail("You shouldn't be able to call save(File) to overwrite the current file");
} catch(InvalidOperationException e) {}
-
+
+ p.close();
// Delete it
assertTrue(tempFile.delete());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org
Re: svn commit: r982911 - /poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.ja
va
Posted by Yegor Kozlov <ye...@dinom.ru>.
I don't think it blocks the release. So far so good and I'm going to
post my positive vote on Monday.
The lesson should be to freeze code a week before cutting a
release.Testing on different platforms takes time - I usually test on
Win7, Mac and Solaris and on JDK 1.5 and 1.6. It takes at least a full
day to make sure that trunk is OK on all these platforms.
Yegor
> On Fri, 6 Aug 2010, yegor@apache.org wrote:
>> URL: http://svn.apache.org/viewvc?rev=982911&view=rev
>> Log:
>> close OPC package before assertion, otherwise the test fails on Win7
>> (unix-based systems always pass)
>
> Bah, I thought I'd written that test so it would pass on all
> platforms, assuming the bug I'd fixed was correctly fixed :/
>
> Guess we should re-run the beta artificats + votes with your two
> platform fixes in them?
>
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: svn commit: r982911 -
/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.ja
va
Posted by Nick Burch <ni...@alfresco.com>.
On Fri, 6 Aug 2010, yegor@apache.org wrote:
> URL: http://svn.apache.org/viewvc?rev=982911&view=rev
> Log:
> close OPC package before assertion, otherwise the test fails on Win7
> (unix-based systems always pass)
Bah, I thought I'd written that test so it would pass on all platforms,
assuming the bug I'd fixed was correctly fixed :/
Guess we should re-run the beta artificats + votes with your two platform
fixes in them?
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org