You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/05 13:54:12 UTC

[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #340: chore: optimize dockerfile

membphis commented on a change in pull request #340:
URL: https://github.com/apache/apisix-ingress-controller/pull/340#discussion_r607099791



##########
File path: Dockerfile
##########
@@ -22,6 +22,10 @@ RUN rm -rf /etc/localtime \
     && dpkg-reconfigure -f noninteractive tzdata
 
 WORKDIR /build
+COPY go.mod .
+COPY go.sum .
+RUN GOPROXY=https://goproxy.cn,direct go mod download

Review comment:
       Is it better to add parameters to make this step optional? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org