You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "taiyinglee (JIRA)" <ji...@apache.org> on 2018/06/15 07:24:00 UTC

[jira] [Updated] (HBASE-20737) put collection into ArrayList instead of addAll function

     [ https://issues.apache.org/jira/browse/HBASE-20737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

taiyinglee updated HBASE-20737:
-------------------------------
    Description: 
[https://docs.oracle.com/javase/7/docs/api/java/util/Collection.html]

[https://docs.oracle.com/javase/7/docs/api/java/util/ArrayList.html]

[https://docs.oracle.com/javase/7/docs/api/java/util/Set.html]

 

/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterStatusPublisher.java

change

List<Map.Entry<ServerName, Integer>> entries = new ArrayList<>();
 entries.addAll(lastSent.entrySet());

to

List<Map.Entry<ServerName, Integer>> entries = new ArrayList<>(lastSent.entrySet());

  was:
[https://docs.oracle.com/javase/7/docs/api/java/util/Collection.html]

[https://docs.oracle.com/javase/7/docs/api/java/util/ArrayList.html]

[https://docs.oracle.com/javase/7/docs/api/java/util/Set.html]

change

List<Map.Entry<ServerName, Integer>> entries = new ArrayList<>();
 entries.addAll(lastSent.entrySet());

to

List<Map.Entry<ServerName, Integer>> entries = new ArrayList<>(lastSent.entrySet());


> put collection into ArrayList instead of addAll function
> --------------------------------------------------------
>
>                 Key: HBASE-20737
>                 URL: https://issues.apache.org/jira/browse/HBASE-20737
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: taiyinglee
>            Assignee: taiyinglee
>            Priority: Trivial
>
> [https://docs.oracle.com/javase/7/docs/api/java/util/Collection.html]
> [https://docs.oracle.com/javase/7/docs/api/java/util/ArrayList.html]
> [https://docs.oracle.com/javase/7/docs/api/java/util/Set.html]
>  
> /hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterStatusPublisher.java
> change
> List<Map.Entry<ServerName, Integer>> entries = new ArrayList<>();
>  entries.addAll(lastSent.entrySet());
> to
> List<Map.Entry<ServerName, Integer>> entries = new ArrayList<>(lastSent.entrySet());



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)