You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by joan38 <gi...@git.apache.org> on 2016/04/14 21:21:06 UTC
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
GitHub user joan38 opened a pull request:
https://github.com/apache/spark/pull/12401
[SPARK-14640] Add @DeveloperApi on PythonUserDefinedType
## What changes were proposed in this pull request?
Add @DeveloperApi on PythonUserDefinedType
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joan38/spark SPARK-14640-PythonUserDefinedType
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12401.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12401
----
commit ed200fd27a59190bf47c601fe2822007a0934312
Author: Joan <jo...@goyeau.com>
Date: 2016-04-14T19:19:53Z
Add @DeveloperApi on PythonUserDefinedType
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12401#issuecomment-210142996
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55838/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12401#issuecomment-210142993
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12401#issuecomment-210146090
In general `@DeveloperApi`s are only used for public classes. What is the motivation for adding this here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12401
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by joan38 <gi...@git.apache.org>.
Github user joan38 commented on the pull request:
https://github.com/apache/spark/pull/12401#issuecomment-211466903
@andrewor14 Sorry I've been confused by the `::DeveloperApi::` in comments.
Should we remove `::DeveloperApi::` from the comment then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12401#issuecomment-210109231
**[Test build #55838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55838/consoleFull)** for PR 12401 at commit [`ed200fd`](https://github.com/apache/spark/commit/ed200fd27a59190bf47c601fe2822007a0934312).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12401#issuecomment-210142477
**[Test build #55838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55838/consoleFull)** for PR 12401 at commit [`ed200fd`](https://github.com/apache/spark/commit/ed200fd27a59190bf47c601fe2822007a0934312).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12401#issuecomment-211486416
Oh now I see why you did that. Yeah it doesn't even make sense to add a `::DeveloperApi::` to something without an annotation. I would remove that comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14640] Add @DeveloperApi on PythonUserD...
Posted by joan38 <gi...@git.apache.org>.
Github user joan38 commented on the pull request:
https://github.com/apache/spark/pull/12401#issuecomment-211487546
Cheers @andrewor14 for the clarification. I will do a PR for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org