You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/02/26 01:28:59 UTC
[GitHub] [hadoop] xinglin opened a new pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
xinglin opened a new pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
Modified getTrashRoot/s to return viewFS path for the new trash location.
If CONFIG_VIEWFS_TRASH_ROOT_UNDER_MOUNT_POINT_ROOT is not set, return the default trash root (a targetFS path) from targetFS.
When CONFIG_VIEWFS_TRASH_ROOT_UNDER_MOUNT_POINT_ROOT is set to true,
1) If path p is in a snapshot or encryption zone, or when it is in the
fallback FS, return the default trash root (a targetFS path) from targetFS.
2) else, return a viewFS path for the trash root under the root of the
mount point (/mntpoint/.Trash/{user}).
### How was this patch tested?
Run unit tests manually from intellij.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1059727906
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 18m 37s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 45s | | trunk passed |
| +1 :green_heart: | compile | 30m 5s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 25m 21s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 1s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 44s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 10s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 40s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 46s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 9s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 4s | | the patch passed |
| +1 :green_heart: | compile | 29m 42s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 29m 42s | | the patch passed |
| +1 :green_heart: | compile | 27m 24s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 27m 24s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 2s | [/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/7/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt) | hadoop-common-project/hadoop-common: The patch generated 1 new + 104 unchanged - 0 fixed = 105 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 40s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 8s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 43s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 4s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 27s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 18m 18s | [/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt) | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 51s | | The patch does not generate ASF License warnings. |
| | | 254m 29s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem |
| | hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/7/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 521a62046310 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 36b5e3d4de905ec1bf9a747802be8753818818b9 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/7/testReport/ |
| Max. process+thread count | 2611 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/7/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xinglin commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
xinglin commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r820035459
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
##########
@@ -191,8 +191,8 @@ public boolean moveToTrash(Path path) throws IOException {
cause = e;
}
}
- throw (IOException)
- new IOException("Failed to move to trash: " + path).initCause(cause);
+ throw (IOException) new IOException(
Review comment:
yeah, it is a by-product of a small change: I added to print the trashPath as well and we can not fit in one line, thus breaking into two lines.
it is changed from
```
throw (IOException)
new IOException("Failed to move to trash" + path).initCause(cause);
```
to
```
throw (IOException) new IOException(
"Failed to move " + path + " to trash " + trashPath).initCause(cause);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xinglin commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
xinglin commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r823155360
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1128,51 +1128,58 @@ public BlockStoragePolicySpi getStoragePolicy(Path src) throws IOException {
return allPolicies;
}
+ // Test whether a path is inside a snapshot or encrypted.
+ boolean isSnapshotEnabledOrEncrypted(Path p) throws IOException {
+ try {
+ FileStatus status = getFileStatus(p);
+ return status.isSnapshotEnabled() || status.isEncrypted();
Review comment:
reverted to use path length comparison approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1061148701
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 3s | | trunk passed |
| +1 :green_heart: | compile | 25m 16s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 22m 1s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 1s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 51s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 10s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 46s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 30s | | trunk passed |
| +1 :green_heart: | shadedclient | 21m 58s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 2s | | the patch passed |
| +1 :green_heart: | compile | 24m 23s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 24m 23s | | the patch passed |
| +1 :green_heart: | compile | 21m 49s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 21m 49s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 10s | | hadoop-common-project/hadoop-common: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 41s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 17s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 38s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 39s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 8s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 18m 5s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 55s | | The patch does not generate ASF License warnings. |
| | | 208m 10s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/10/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 19ef1db642ab 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 10f1436fed70a73c71a641a6c1d8b14a2e1af4fc |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/10/testReport/ |
| Max. process+thread count | 1250 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/10/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1062468317
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 20s | | trunk passed |
| +1 :green_heart: | compile | 22m 43s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 19m 51s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 7s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 44s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 14s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 43s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 32s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 28s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 2s | | the patch passed |
| +1 :green_heart: | compile | 21m 57s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 21m 57s | | the patch passed |
| +1 :green_heart: | compile | 19m 48s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 19m 48s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 6s | | hadoop-common-project/hadoop-common: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 39s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 12s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 47s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 2m 42s | [/new-spotbugs-hadoop-common-project_hadoop-common.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/14/artifact/out/new-spotbugs-hadoop-common-project_hadoop-common.html) | hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | shadedclient | 22m 29s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 49s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 51s | | The patch does not generate ASF License warnings. |
| | | 200m 12s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hadoop-common-project/hadoop-common |
| | Call to org.apache.hadoop.fs.Path.equals(String) in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java: At ViewFileSystem.java:[line 1194] |
| | Nullcheck of mountTargetPath at line 1186 of value previously dereferenced in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java:1186 of value previously dereferenced in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java:[line 1186] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/14/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 6cdb81396a21 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / af3071503d9353b1be18008f4daec7093128b2aa |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/14/testReport/ |
| Max. process+thread count | 3127 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/14/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1062518869
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 6s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 37m 27s | | trunk passed |
| +1 :green_heart: | compile | 25m 31s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 23m 31s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 2s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 39s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 8s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 39s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 34s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 31s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 1s | | the patch passed |
| +1 :green_heart: | compile | 25m 6s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 25m 6s | | the patch passed |
| +1 :green_heart: | compile | 21m 53s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 21m 53s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 58s | | hadoop-common-project/hadoop-common: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 35s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 8s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 38s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 41s | | the patch passed |
| +1 :green_heart: | shadedclient | 26m 3s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 18m 1s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 49s | | The patch does not generate ASF License warnings. |
| | | 221m 24s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/15/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 55512a60ee3c 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 808749d4b5a469dc1096e364b7146e3b377da23a |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/15/testReport/ |
| Max. process+thread count | 3137 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/15/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ibuenros commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
ibuenros commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r819904428
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
##########
@@ -191,8 +191,8 @@ public boolean moveToTrash(Path path) throws IOException {
cause = e;
}
}
- throw (IOException)
- new IOException("Failed to move to trash: " + path).initCause(cause);
+ throw (IOException) new IOException(
Review comment:
nit: Is this change intentional? i.e. removing the line break?
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java
##########
@@ -134,8 +134,10 @@
HCFSMountTableConfigLoader.class;
/**
- * Enable ViewFileSystem to return a trashRoot which is local to mount point.
+ * Enable ViewFileSystem to return a trashRoot which is in the root dir of a
+ * mount point.
*/
- String CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH = "fs.viewfs.mount.point.local.trash";
- boolean CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT = false;
+ String CONFIG_VIEWFS_TRASH_ROOT_UNDER_MOUNT_POINT_ROOT =
+ "fs.viewfs.trash.root.under.mount.point.root";
Review comment:
Why are we changing the configuration? Also @omalley what's Hadoop's policy on using dots as spaces as opposed to dots as hierarchical separators? i.e. should this be fs.viewfs.trash.rootUnderMountPointRoot?
##########
File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
##########
@@ -1141,60 +1143,52 @@ public void testTrashRootLocalizedTrash() throws IOException {
fsView2.getTrashRoot(nonExistentPath);
} catch (NotInMountpointException ignored) {
}
-
- // Case 5: path p is in the same mount point as targetFS.getTrashRoot().
- // Return targetFS.getTrashRoot()
- // Use a new Configuration object, so that we can start with an empty
- // mount table. This would avoid a conflict between the /user link in
- // setupMountPoints() and homeDir we will need to setup for this test.
- // default homeDir for hdfs is /user/.
- Configuration conf3 = ViewFileSystemTestSetup.createConfig();
- Path homeDir = fsTarget.getHomeDirectory();
- String homeParentDir = homeDir.getParent().toUri().getPath();
- conf3.setBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH, true);
- ConfigUtil.addLink(conf3, homeParentDir,
- new Path(targetTestRoot, homeParentDir).toUri());
- Path homeTestPath = new Path(homeDir.toUri().getPath(), "testuser/file");
- FileSystem fsView3 = FileSystem.get(FsConstants.VIEWFS_URI, conf3);
- Assert.assertEquals(userTrashRoot, fsView3.getTrashRoot(homeTestPath));
}
/**
- * A mocked FileSystem which returns a deep trash dir.
+ * A mocked FileSystem which returns overwrites getFileStatus() to always
+ * return an encrypted FileStatus.
*/
static class MockTrashRootFS extends MockFileSystem {
Review comment:
nit: make the name reflect the behavior, e.g. `AllPathsAreEncryptionRootsFS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1059716994
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 13m 19s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 34m 4s | | trunk passed |
| +1 :green_heart: | compile | 25m 7s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 21m 5s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 0s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 38s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 11s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 37s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 32s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 29s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 1s | | the patch passed |
| +1 :green_heart: | compile | 22m 46s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 22m 46s | | the patch passed |
| +1 :green_heart: | compile | 21m 14s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 21m 14s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 3s | [/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/4/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt) | hadoop-common-project/hadoop-common: The patch generated 1 new + 104 unchanged - 0 fixed = 105 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 41s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 8s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 40s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 54s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 44s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 18m 36s | [/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt) | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | | The patch does not generate ASF License warnings. |
| | | 222m 47s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem |
| | hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux e0536a66a06c 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / a278cbccb6585cad126cc6793391a4484f5f3719 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/4/testReport/ |
| Max. process+thread count | 1985 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/4/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] omalley closed pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
omalley closed pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1059720985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1051612044
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 4s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 39s | | trunk passed |
| +1 :green_heart: | compile | 28m 30s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 22m 30s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 59s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 36s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 8s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 39s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 41s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 48s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 3s | | the patch passed |
| +1 :green_heart: | compile | 26m 56s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 26m 56s | | the patch passed |
| +1 :green_heart: | compile | 25m 27s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 25m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 12s | [/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/1/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt) | hadoop-common-project/hadoop-common: The patch generated 1 new + 104 unchanged - 0 fixed = 105 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 58s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 26s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 55s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 6s | | the patch passed |
| +1 :green_heart: | shadedclient | 29m 46s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 26m 16s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 1m 2s | | The patch does not generate ASF License warnings. |
| | | 242m 25s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 92a45d2567e3 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 26cb868b7acfd20853da172b79ad02658e33978e |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/1/testReport/ |
| Max. process+thread count | 1538 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1065926053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xinglin commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
xinglin commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r820035459
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
##########
@@ -191,8 +191,8 @@ public boolean moveToTrash(Path path) throws IOException {
cause = e;
}
}
- throw (IOException)
- new IOException("Failed to move to trash: " + path).initCause(cause);
+ throw (IOException) new IOException(
Review comment:
yeah, it is sort of intentional: I added to print the trashPath as well and we can not fit in one line, thus breaking into two lines.
it is changed from
```
throw (IOException)
new IOException("Failed to move to trash" + path).initCause(cause);
```
to
```
throw (IOException) new IOException(
"Failed to move " + path + " to trash " + trashPath).initCause(cause);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1059716961
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 17m 19s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 15s | | trunk passed |
| +1 :green_heart: | compile | 28m 23s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 24m 54s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 1s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 44s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 14s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 45s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 47s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 44s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 7s | | the patch passed |
| +1 :green_heart: | compile | 28m 6s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 28m 6s | | the patch passed |
| +1 :green_heart: | compile | 24m 34s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 24m 34s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 58s | [/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/2/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt) | hadoop-common-project/hadoop-common: The patch generated 1 new + 104 unchanged - 0 fixed = 105 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 44s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 10s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 42s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 53s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 46s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 18m 13s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 51s | | The patch does not generate ASF License warnings. |
| | | 247m 13s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 348693885b31 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 62f44d30bc3749349f96987fddcb4fa378fd6d66 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/2/testReport/ |
| Max. process+thread count | 1374 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/2/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1059728061
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 12m 53s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 59s | | trunk passed |
| +1 :green_heart: | compile | 30m 7s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 25m 26s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 59s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 45s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 10s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 42s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 48s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 24s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 11s | | the patch passed |
| +1 :green_heart: | compile | 29m 32s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 29m 32s | | the patch passed |
| +1 :green_heart: | compile | 27m 50s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 27m 50s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 6s | [/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/8/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt) | hadoop-common-project/hadoop-common: The patch generated 1 new + 104 unchanged - 0 fixed = 105 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 39s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 8s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 43s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 1s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 35s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 18m 15s | [/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/8/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt) | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 50s | | The patch does not generate ASF License warnings. |
| | | 250m 5s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem |
| | hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/8/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux e44ca3384d74 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 36b5e3d4de905ec1bf9a747802be8753818818b9 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/8/testReport/ |
| Max. process+thread count | 1243 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/8/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1061148464
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 24s | | trunk passed |
| +1 :green_heart: | compile | 25m 21s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 22m 8s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 5s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 39s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 19s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 45s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 41s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 25s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 0s | | the patch passed |
| +1 :green_heart: | compile | 24m 38s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 24m 38s | | the patch passed |
| +1 :green_heart: | compile | 22m 1s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 22m 1s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 0s | | hadoop-common-project/hadoop-common: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 43s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 14s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 50s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 44s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 44s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 18m 9s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | | The patch does not generate ASF License warnings. |
| | | 210m 25s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/9/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 7f4ddfdfc259 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 10f1436fed70a73c71a641a6c1d8b14a2e1af4fc |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/9/testReport/ |
| Max. process+thread count | 2184 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/9/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1061145999
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 6s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 14s | | trunk passed |
| +1 :green_heart: | compile | 22m 27s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 19m 43s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 7s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 41s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 13s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 40s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 32s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 7s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 0s | | the patch passed |
| +1 :green_heart: | compile | 21m 35s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 21m 35s | | the patch passed |
| +1 :green_heart: | compile | 19m 41s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 19m 41s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 8s | | hadoop-common-project/hadoop-common: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 41s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 10s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 44s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 38s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 10s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 47s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | | The patch does not generate ASF License warnings. |
| | | 197m 40s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/11/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux eea358b2c5cd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 28bff6a3ab3b05229a2650da53434e3a81e45593 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/11/testReport/ |
| Max. process+thread count | 1825 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/11/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1066973576
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 4 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 25s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 25m 38s | | trunk passed |
| +1 :green_heart: | compile | 24m 26s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 21m 15s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 3m 53s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 20s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 21s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 3m 25s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 6m 13s | | trunk passed |
| +1 :green_heart: | shadedclient | 26m 20s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 21s | | the patch passed |
| +1 :green_heart: | compile | 23m 46s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 23m 46s | | the patch passed |
| +1 :green_heart: | compile | 21m 0s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 21m 0s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 3m 43s | | root: The patch generated 0 new + 110 unchanged - 1 fixed = 110 total (was 111) |
| +1 :green_heart: | mvnsite | 3m 17s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 15s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 3m 24s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 6m 25s | | the patch passed |
| +1 :green_heart: | shadedclient | 26m 36s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 34s | | hadoop-common in the patch passed. |
| +1 :green_heart: | unit | 352m 35s | | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 57s | | The patch does not generate ASF License warnings. |
| | | 592m 13s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/19/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux bb8cb6fdec52 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 15a6dcc00772fca320e0dab9322dfdafb2e3fa67 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/19/testReport/ |
| Max. process+thread count | 2060 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/19/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xinglin commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
xinglin commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r820037169
##########
File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
##########
@@ -1141,60 +1143,52 @@ public void testTrashRootLocalizedTrash() throws IOException {
fsView2.getTrashRoot(nonExistentPath);
} catch (NotInMountpointException ignored) {
}
-
- // Case 5: path p is in the same mount point as targetFS.getTrashRoot().
- // Return targetFS.getTrashRoot()
- // Use a new Configuration object, so that we can start with an empty
- // mount table. This would avoid a conflict between the /user link in
- // setupMountPoints() and homeDir we will need to setup for this test.
- // default homeDir for hdfs is /user/.
- Configuration conf3 = ViewFileSystemTestSetup.createConfig();
- Path homeDir = fsTarget.getHomeDirectory();
- String homeParentDir = homeDir.getParent().toUri().getPath();
- conf3.setBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH, true);
- ConfigUtil.addLink(conf3, homeParentDir,
- new Path(targetTestRoot, homeParentDir).toUri());
- Path homeTestPath = new Path(homeDir.toUri().getPath(), "testuser/file");
- FileSystem fsView3 = FileSystem.get(FsConstants.VIEWFS_URI, conf3);
- Assert.assertEquals(userTrashRoot, fsView3.getTrashRoot(homeTestPath));
}
/**
- * A mocked FileSystem which returns a deep trash dir.
+ * A mocked FileSystem which returns overwrites getFileStatus() to always
+ * return an encrypted FileStatus.
*/
static class MockTrashRootFS extends MockFileSystem {
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] omalley commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
omalley commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r821086272
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1132,47 +1132,71 @@ public BlockStoragePolicySpi getStoragePolicy(Path src) throws IOException {
* Get the trash root directory for current user when the path
* specified is deleted.
*
- * If CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is not set, return
- * the default trash root from targetFS.
+ * If FORCE_INSIDE_MOUNT_POINT flag is not set, return the default trash root
+ * from targetFS.
*
- * When CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is set to true,
- * 1) If path p is in fallback FS or from the same mount point as the default
- * trash root for targetFS, return the default trash root for targetFS.
- * 2) else, return a trash root in the mounted targetFS
- * (/mntpoint/.Trash/{user})
+ * When FORCE_INSIDE_MOUNT_POINT is set to true,
+ * 1) If path p in fallback FS, return trash root from fallback FS. Print a
+ * warning if there is a mount point for the trash root.
+ * 2) If the trash root for path p is in the same mount point as path p,
+ * when trashRoot.startWith(mountPoint.destPath) == true,
+ * get the corresponding viewFS path for the trash root and return it.
+ * 3) else, return the trash root under the root of the mount point
+ * (/mntpoint/.Trash/{user}).
*
* @param path the trash root of the path to be determined.
* @return the trash root path.
*/
@Override
public Path getTrashRoot(Path path) {
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
+ boolean trashForceInsideMountPoint =
Review comment:
Push this down closer to where it is used.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1132,47 +1132,71 @@ public BlockStoragePolicySpi getStoragePolicy(Path src) throws IOException {
* Get the trash root directory for current user when the path
* specified is deleted.
*
- * If CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is not set, return
- * the default trash root from targetFS.
+ * If FORCE_INSIDE_MOUNT_POINT flag is not set, return the default trash root
+ * from targetFS.
*
- * When CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is set to true,
- * 1) If path p is in fallback FS or from the same mount point as the default
- * trash root for targetFS, return the default trash root for targetFS.
- * 2) else, return a trash root in the mounted targetFS
- * (/mntpoint/.Trash/{user})
+ * When FORCE_INSIDE_MOUNT_POINT is set to true,
+ * 1) If path p in fallback FS, return trash root from fallback FS. Print a
+ * warning if there is a mount point for the trash root.
+ * 2) If the trash root for path p is in the same mount point as path p,
+ * when trashRoot.startWith(mountPoint.destPath) == true,
+ * get the corresponding viewFS path for the trash root and return it.
+ * 3) else, return the trash root under the root of the mount point
+ * (/mntpoint/.Trash/{user}).
*
* @param path the trash root of the path to be determined.
* @return the trash root path.
*/
@Override
public Path getTrashRoot(Path path) {
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
try {
InodeTree.ResolveResult<FileSystem> res =
fsState.resolve(getUriPath(path), true);
- Path trashRoot = res.targetFileSystem.getTrashRoot(res.remainingPath);
- if (!useMountPointLocalTrash) {
- return trashRoot;
- } else {
- // Path p is either in a mount point or in the fallback FS
+ Path targetFSTrashRoot =
+ res.targetFileSystem.getTrashRoot(res.remainingPath);
+ String targetFSTrashRootPath = targetFSTrashRoot.toUri().getPath();
+ String mountTargetPath = res.targetFileSystem.getUri().getPath();
- if (ROOT_PATH.equals(new Path(res.resolvedPath))
- || trashRoot.toUri().getPath().startsWith(res.resolvedPath)) {
- // Path p is in the fallback FS or targetFileSystem.trashRoot is in
- // the same mount point as Path p
- return trashRoot;
- } else {
- // targetFileSystem.trashRoot is in a different mount point from
- // Path p. Return the trash root for the mount point.
- Path mountPointRoot =
- res.targetFileSystem.getFileStatus(new Path("/")).getPath();
- return new Path(mountPointRoot,
- TRASH_PREFIX + "/" + ugi.getShortUserName());
+ if (!trashForceInsideMountPoint) {
+ return targetFSTrashRoot;
+ }
+
+ // New trash root policy
+ if (ROOT_PATH.equals(new Path(res.resolvedPath))) {
+ // Path path is in fallback FS. Return targetFSTrashRootPath;
+
+ // Check and print a warning if a mountpoint exists for
+ // targetFSTrashRootPath. The trash root from fallback FS should be in
+ // the fallback FS, not in a different mount point.
+ InodeTree.ResolveResult<FileSystem> res2 =
+ fsState.resolve(targetFSTrashRootPath, true);
+ if (!ROOT_PATH.equals(new Path(res2.resolvedPath))) {
+ LOG.warn(String.format("A mount point %s exists for trash root %s "
+ + "returned by fallback FS for path %s. Rename between path %s "
+ + "and trash root %s will fail, as the trash root is in a "
+ + "mount point while path %s is in the fallback FS",
+ res2.resolvedPath, targetFSTrashRootPath, path, path,
+ targetFSTrashRootPath, path));
}
+ return new Path(targetFSTrashRootPath);
Review comment:
This needs to be made fully qualified using fs.makeQualified(...).
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1192,59 +1219,66 @@ public Path getTrashRoot(Path path) {
trashRoots.addAll(fs.getTrashRoots(allUsers));
}
- // Add trash dirs for each mount point
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
- if (useMountPointLocalTrash) {
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
+ // Return trashRoots if FORCE_INSIDE_MOUNT_POINT is disabled.
+ if (!trashForceInsideMountPoint) {
+ return trashRoots;
+ }
- Set<Path> currentTrashPaths = new HashSet<>();
- for (FileStatus file : trashRoots) {
- currentTrashPaths.add(file.getPath());
- }
+ // We use targetFS Path to check for duplicate paths.
+ Set<Path> uniqueTrashRoots = new HashSet<>();
+ for (FileStatus file : trashRoots) {
+ uniqueTrashRoots.add(file.getPath());
+ }
- MountPoint[] mountPoints = getMountPoints();
- try {
- for (int i = 0; i < mountPoints.length; i++) {
- Path trashRoot = makeQualified(
- new Path(mountPoints[i].mountedOnPath + "/" + TRASH_PREFIX));
+ List<InodeTree.MountPoint<FileSystem>> mountPoints =
+ fsState.getMountPoints();
+ try {
+ for (InodeTree.MountPoint<FileSystem> mountPoint : mountPoints) {
- // Continue if trashRoot does not exist for this filesystem
- if (!exists(trashRoot)) {
- continue;
- }
+ Path trashRoot = new Path(mountPoint.src + "/" + TRASH_PREFIX);
- InodeTree.ResolveResult<FileSystem> res =
- fsState.resolve(getUriPath(trashRoot), true);
+ // Continue if trashRoot does not exist for this mount point
+ if (!exists(trashRoot)) {
+ continue;
+ }
- if (!allUsers) {
- Path userTrash =
+ if (!allUsers) {
+ Path userTrashRoot = new Path(trashRoot, ugi.getShortUserName());
+ if (exists(userTrashRoot)) {
+ Path targetFsTrashPath =
new Path("/" + TRASH_PREFIX + "/" + ugi.getShortUserName());
- try {
- FileStatus file = res.targetFileSystem.getFileStatus(userTrash);
- if (!currentTrashPaths.contains(file.getPath())) {
- trashRoots.add(file);
- currentTrashPaths.add(file.getPath());
- }
- } catch (FileNotFoundException ignored) {
+ FileStatus targetFsTrash = mountPoint.target.getTargetFileSystem()
+ .getFileStatus(targetFsTrashPath);
+ if (!uniqueTrashRoots.contains(targetFsTrash.getPath())) {
Review comment:
With a HashMap, you don't need to test it first. Just update the map.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
##########
@@ -191,8 +191,8 @@ public boolean moveToTrash(Path path) throws IOException {
cause = e;
}
}
- throw (IOException)
- new IOException("Failed to move to trash: " + path).initCause(cause);
+ throw (IOException) new IOException(
Review comment:
@ibuenros and my original comment was about removing the line break. Changing the message is a little risky, but ok.
Please change this to
throw new IOException("Failed ..." + ..., cause);
IOException has a constructor that takes a cause and thus you don't need the cast or separate initCause.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1192,59 +1219,66 @@ public Path getTrashRoot(Path path) {
trashRoots.addAll(fs.getTrashRoots(allUsers));
}
- // Add trash dirs for each mount point
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
- if (useMountPointLocalTrash) {
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
+ // Return trashRoots if FORCE_INSIDE_MOUNT_POINT is disabled.
+ if (!trashForceInsideMountPoint) {
+ return trashRoots;
+ }
- Set<Path> currentTrashPaths = new HashSet<>();
- for (FileStatus file : trashRoots) {
- currentTrashPaths.add(file.getPath());
- }
+ // We use targetFS Path to check for duplicate paths.
+ Set<Path> uniqueTrashRoots = new HashSet<>();
Review comment:
The return can be trashRoots.values().
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1132,47 +1132,71 @@ public BlockStoragePolicySpi getStoragePolicy(Path src) throws IOException {
* Get the trash root directory for current user when the path
* specified is deleted.
*
- * If CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is not set, return
- * the default trash root from targetFS.
+ * If FORCE_INSIDE_MOUNT_POINT flag is not set, return the default trash root
+ * from targetFS.
*
- * When CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is set to true,
- * 1) If path p is in fallback FS or from the same mount point as the default
- * trash root for targetFS, return the default trash root for targetFS.
- * 2) else, return a trash root in the mounted targetFS
- * (/mntpoint/.Trash/{user})
+ * When FORCE_INSIDE_MOUNT_POINT is set to true,
+ * 1) If path p in fallback FS, return trash root from fallback FS. Print a
+ * warning if there is a mount point for the trash root.
+ * 2) If the trash root for path p is in the same mount point as path p,
+ * when trashRoot.startWith(mountPoint.destPath) == true,
+ * get the corresponding viewFS path for the trash root and return it.
+ * 3) else, return the trash root under the root of the mount point
+ * (/mntpoint/.Trash/{user}).
*
* @param path the trash root of the path to be determined.
* @return the trash root path.
*/
@Override
public Path getTrashRoot(Path path) {
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
try {
InodeTree.ResolveResult<FileSystem> res =
fsState.resolve(getUriPath(path), true);
- Path trashRoot = res.targetFileSystem.getTrashRoot(res.remainingPath);
- if (!useMountPointLocalTrash) {
- return trashRoot;
- } else {
- // Path p is either in a mount point or in the fallback FS
+ Path targetFSTrashRoot =
+ res.targetFileSystem.getTrashRoot(res.remainingPath);
+ String targetFSTrashRootPath = targetFSTrashRoot.toUri().getPath();
+ String mountTargetPath = res.targetFileSystem.getUri().getPath();
- if (ROOT_PATH.equals(new Path(res.resolvedPath))
- || trashRoot.toUri().getPath().startsWith(res.resolvedPath)) {
- // Path p is in the fallback FS or targetFileSystem.trashRoot is in
- // the same mount point as Path p
- return trashRoot;
- } else {
- // targetFileSystem.trashRoot is in a different mount point from
- // Path p. Return the trash root for the mount point.
- Path mountPointRoot =
- res.targetFileSystem.getFileStatus(new Path("/")).getPath();
- return new Path(mountPointRoot,
- TRASH_PREFIX + "/" + ugi.getShortUserName());
+ if (!trashForceInsideMountPoint) {
+ return targetFSTrashRoot;
+ }
+
+ // New trash root policy
+ if (ROOT_PATH.equals(new Path(res.resolvedPath))) {
+ // Path path is in fallback FS. Return targetFSTrashRootPath;
+
+ // Check and print a warning if a mountpoint exists for
+ // targetFSTrashRootPath. The trash root from fallback FS should be in
+ // the fallback FS, not in a different mount point.
+ InodeTree.ResolveResult<FileSystem> res2 =
+ fsState.resolve(targetFSTrashRootPath, true);
+ if (!ROOT_PATH.equals(new Path(res2.resolvedPath))) {
+ LOG.warn(String.format("A mount point %s exists for trash root %s "
+ + "returned by fallback FS for path %s. Rename between path %s "
+ + "and trash root %s will fail, as the trash root is in a "
+ + "mount point while path %s is in the fallback FS",
+ res2.resolvedPath, targetFSTrashRootPath, path, path,
+ targetFSTrashRootPath, path));
}
+ return new Path(targetFSTrashRootPath);
+ } else if (targetFSTrashRootPath.startsWith(mountTargetPath)) {
+ // targetFSTrash is inside mountPoint.targetPath
+ String relativeTrashRoot =
+ targetFSTrashRootPath.substring(mountTargetPath.length());
+ // remove the starting '/' if it exists
+ if (relativeTrashRoot.startsWith("/")) {
+ relativeTrashRoot = relativeTrashRoot.substring(1);
+ }
+ return new Path(res.resolvedPath, relativeTrashRoot);
Review comment:
This also needs to be made fully qualified.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1192,59 +1219,66 @@ public Path getTrashRoot(Path path) {
trashRoots.addAll(fs.getTrashRoots(allUsers));
}
- // Add trash dirs for each mount point
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
- if (useMountPointLocalTrash) {
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
+ // Return trashRoots if FORCE_INSIDE_MOUNT_POINT is disabled.
+ if (!trashForceInsideMountPoint) {
+ return trashRoots;
+ }
- Set<Path> currentTrashPaths = new HashSet<>();
- for (FileStatus file : trashRoots) {
- currentTrashPaths.add(file.getPath());
- }
+ // We use targetFS Path to check for duplicate paths.
+ Set<Path> uniqueTrashRoots = new HashSet<>();
+ for (FileStatus file : trashRoots) {
+ uniqueTrashRoots.add(file.getPath());
+ }
- MountPoint[] mountPoints = getMountPoints();
- try {
- for (int i = 0; i < mountPoints.length; i++) {
- Path trashRoot = makeQualified(
- new Path(mountPoints[i].mountedOnPath + "/" + TRASH_PREFIX));
+ List<InodeTree.MountPoint<FileSystem>> mountPoints =
+ fsState.getMountPoints();
+ try {
+ for (InodeTree.MountPoint<FileSystem> mountPoint : mountPoints) {
- // Continue if trashRoot does not exist for this filesystem
- if (!exists(trashRoot)) {
- continue;
- }
+ Path trashRoot = new Path(mountPoint.src + "/" + TRASH_PREFIX);
- InodeTree.ResolveResult<FileSystem> res =
- fsState.resolve(getUriPath(trashRoot), true);
+ // Continue if trashRoot does not exist for this mount point
+ if (!exists(trashRoot)) {
+ continue;
+ }
- if (!allUsers) {
- Path userTrash =
+ if (!allUsers) {
+ Path userTrashRoot = new Path(trashRoot, ugi.getShortUserName());
+ if (exists(userTrashRoot)) {
+ Path targetFsTrashPath =
Review comment:
Use the userTrashRoot, so that it is fully qualified in the viewfs.
You want the FileStatus to be in the viewfs, not the underlying filesystem.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1132,47 +1132,71 @@ public BlockStoragePolicySpi getStoragePolicy(Path src) throws IOException {
* Get the trash root directory for current user when the path
* specified is deleted.
*
- * If CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is not set, return
- * the default trash root from targetFS.
+ * If FORCE_INSIDE_MOUNT_POINT flag is not set, return the default trash root
+ * from targetFS.
*
- * When CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is set to true,
- * 1) If path p is in fallback FS or from the same mount point as the default
- * trash root for targetFS, return the default trash root for targetFS.
- * 2) else, return a trash root in the mounted targetFS
- * (/mntpoint/.Trash/{user})
+ * When FORCE_INSIDE_MOUNT_POINT is set to true,
+ * 1) If path p in fallback FS, return trash root from fallback FS. Print a
+ * warning if there is a mount point for the trash root.
+ * 2) If the trash root for path p is in the same mount point as path p,
+ * when trashRoot.startWith(mountPoint.destPath) == true,
+ * get the corresponding viewFS path for the trash root and return it.
+ * 3) else, return the trash root under the root of the mount point
+ * (/mntpoint/.Trash/{user}).
*
* @param path the trash root of the path to be determined.
* @return the trash root path.
*/
@Override
public Path getTrashRoot(Path path) {
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
try {
InodeTree.ResolveResult<FileSystem> res =
fsState.resolve(getUriPath(path), true);
- Path trashRoot = res.targetFileSystem.getTrashRoot(res.remainingPath);
- if (!useMountPointLocalTrash) {
- return trashRoot;
- } else {
- // Path p is either in a mount point or in the fallback FS
+ Path targetFSTrashRoot =
+ res.targetFileSystem.getTrashRoot(res.remainingPath);
+ String targetFSTrashRootPath = targetFSTrashRoot.toUri().getPath();
Review comment:
Move these after the check of trashForceInsideMountPoint.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1192,59 +1219,66 @@ public Path getTrashRoot(Path path) {
trashRoots.addAll(fs.getTrashRoots(allUsers));
}
- // Add trash dirs for each mount point
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
- if (useMountPointLocalTrash) {
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
+ // Return trashRoots if FORCE_INSIDE_MOUNT_POINT is disabled.
+ if (!trashForceInsideMountPoint) {
+ return trashRoots;
+ }
- Set<Path> currentTrashPaths = new HashSet<>();
- for (FileStatus file : trashRoots) {
- currentTrashPaths.add(file.getPath());
- }
+ // We use targetFS Path to check for duplicate paths.
+ Set<Path> uniqueTrashRoots = new HashSet<>();
+ for (FileStatus file : trashRoots) {
+ uniqueTrashRoots.add(file.getPath());
+ }
- MountPoint[] mountPoints = getMountPoints();
- try {
- for (int i = 0; i < mountPoints.length; i++) {
- Path trashRoot = makeQualified(
- new Path(mountPoints[i].mountedOnPath + "/" + TRASH_PREFIX));
+ List<InodeTree.MountPoint<FileSystem>> mountPoints =
+ fsState.getMountPoints();
+ try {
+ for (InodeTree.MountPoint<FileSystem> mountPoint : mountPoints) {
- // Continue if trashRoot does not exist for this filesystem
- if (!exists(trashRoot)) {
- continue;
- }
+ Path trashRoot = new Path(mountPoint.src + "/" + TRASH_PREFIX);
- InodeTree.ResolveResult<FileSystem> res =
- fsState.resolve(getUriPath(trashRoot), true);
+ // Continue if trashRoot does not exist for this mount point
+ if (!exists(trashRoot)) {
+ continue;
+ }
- if (!allUsers) {
- Path userTrash =
+ if (!allUsers) {
+ Path userTrashRoot = new Path(trashRoot, ugi.getShortUserName());
+ if (exists(userTrashRoot)) {
+ Path targetFsTrashPath =
new Path("/" + TRASH_PREFIX + "/" + ugi.getShortUserName());
- try {
- FileStatus file = res.targetFileSystem.getFileStatus(userTrash);
- if (!currentTrashPaths.contains(file.getPath())) {
- trashRoots.add(file);
- currentTrashPaths.add(file.getPath());
- }
- } catch (FileNotFoundException ignored) {
+ FileStatus targetFsTrash = mountPoint.target.getTargetFileSystem()
+ .getFileStatus(targetFsTrashPath);
+ if (!uniqueTrashRoots.contains(targetFsTrash.getPath())) {
+ FileStatus trash = getFileStatus(userTrashRoot);
+ trashRoots.add(trash);
+ uniqueTrashRoots.add(targetFsTrash.getPath());
}
- } else {
- FileStatus[] targetFsTrashRoots =
- res.targetFileSystem.listStatus(new Path("/" + TRASH_PREFIX));
- for (FileStatus file : targetFsTrashRoots) {
- // skip if we already include it in currentTrashPaths
- if (currentTrashPaths.contains(file.getPath())) {
- continue;
- }
-
- trashRoots.add(file);
- currentTrashPaths.add(file.getPath());
+ }
+ } else {
+ FileStatus[] mountPointTrashRoots = listStatus(trashRoot);
+ for (FileStatus trash : mountPointTrashRoots) {
+ // Remove the mountPoint to get the targetFS path
+ Path targetFsTrashPath =
Review comment:
Leave these in the viewfs namespace and just add them to the hash map.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1192,59 +1219,66 @@ public Path getTrashRoot(Path path) {
trashRoots.addAll(fs.getTrashRoots(allUsers));
}
- // Add trash dirs for each mount point
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
- if (useMountPointLocalTrash) {
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
+ // Return trashRoots if FORCE_INSIDE_MOUNT_POINT is disabled.
+ if (!trashForceInsideMountPoint) {
+ return trashRoots;
+ }
- Set<Path> currentTrashPaths = new HashSet<>();
- for (FileStatus file : trashRoots) {
- currentTrashPaths.add(file.getPath());
- }
+ // We use targetFS Path to check for duplicate paths.
+ Set<Path> uniqueTrashRoots = new HashSet<>();
Review comment:
I think you should make trashRoots into a HashMap<Path, FileStatus>. Then you don't need to deal with uniqueTrashRoots.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1132,47 +1132,71 @@ public BlockStoragePolicySpi getStoragePolicy(Path src) throws IOException {
* Get the trash root directory for current user when the path
* specified is deleted.
*
- * If CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is not set, return
- * the default trash root from targetFS.
+ * If FORCE_INSIDE_MOUNT_POINT flag is not set, return the default trash root
+ * from targetFS.
*
- * When CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH is set to true,
- * 1) If path p is in fallback FS or from the same mount point as the default
- * trash root for targetFS, return the default trash root for targetFS.
- * 2) else, return a trash root in the mounted targetFS
- * (/mntpoint/.Trash/{user})
+ * When FORCE_INSIDE_MOUNT_POINT is set to true,
+ * 1) If path p in fallback FS, return trash root from fallback FS. Print a
+ * warning if there is a mount point for the trash root.
+ * 2) If the trash root for path p is in the same mount point as path p,
+ * when trashRoot.startWith(mountPoint.destPath) == true,
+ * get the corresponding viewFS path for the trash root and return it.
+ * 3) else, return the trash root under the root of the mount point
+ * (/mntpoint/.Trash/{user}).
*
* @param path the trash root of the path to be determined.
* @return the trash root path.
*/
@Override
public Path getTrashRoot(Path path) {
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
try {
InodeTree.ResolveResult<FileSystem> res =
fsState.resolve(getUriPath(path), true);
- Path trashRoot = res.targetFileSystem.getTrashRoot(res.remainingPath);
- if (!useMountPointLocalTrash) {
- return trashRoot;
- } else {
- // Path p is either in a mount point or in the fallback FS
+ Path targetFSTrashRoot =
+ res.targetFileSystem.getTrashRoot(res.remainingPath);
+ String targetFSTrashRootPath = targetFSTrashRoot.toUri().getPath();
+ String mountTargetPath = res.targetFileSystem.getUri().getPath();
- if (ROOT_PATH.equals(new Path(res.resolvedPath))
- || trashRoot.toUri().getPath().startsWith(res.resolvedPath)) {
- // Path p is in the fallback FS or targetFileSystem.trashRoot is in
- // the same mount point as Path p
- return trashRoot;
- } else {
- // targetFileSystem.trashRoot is in a different mount point from
- // Path p. Return the trash root for the mount point.
- Path mountPointRoot =
- res.targetFileSystem.getFileStatus(new Path("/")).getPath();
- return new Path(mountPointRoot,
- TRASH_PREFIX + "/" + ugi.getShortUserName());
+ if (!trashForceInsideMountPoint) {
+ return targetFSTrashRoot;
+ }
+
+ // New trash root policy
+ if (ROOT_PATH.equals(new Path(res.resolvedPath))) {
+ // Path path is in fallback FS. Return targetFSTrashRootPath;
+
+ // Check and print a warning if a mountpoint exists for
+ // targetFSTrashRootPath. The trash root from fallback FS should be in
+ // the fallback FS, not in a different mount point.
+ InodeTree.ResolveResult<FileSystem> res2 =
+ fsState.resolve(targetFSTrashRootPath, true);
+ if (!ROOT_PATH.equals(new Path(res2.resolvedPath))) {
+ LOG.warn(String.format("A mount point %s exists for trash root %s "
+ + "returned by fallback FS for path %s. Rename between path %s "
+ + "and trash root %s will fail, as the trash root is in a "
+ + "mount point while path %s is in the fallback FS",
+ res2.resolvedPath, targetFSTrashRootPath, path, path,
+ targetFSTrashRootPath, path));
}
+ return new Path(targetFSTrashRootPath);
+ } else if (targetFSTrashRootPath.startsWith(mountTargetPath)) {
+ // targetFSTrash is inside mountPoint.targetPath
+ String relativeTrashRoot =
+ targetFSTrashRootPath.substring(mountTargetPath.length());
+ // remove the starting '/' if it exists
+ if (relativeTrashRoot.startsWith("/")) {
+ relativeTrashRoot = relativeTrashRoot.substring(1);
+ }
+ return new Path(res.resolvedPath, relativeTrashRoot);
+ } else {
+ // Return the trash root for the mount point.
+ return new Path(res.resolvedPath,
Review comment:
And this one.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java
##########
@@ -134,8 +134,9 @@
HCFSMountTableConfigLoader.class;
/**
- * Enable ViewFileSystem to return a trashRoot which is local to mount point.
+ * Force ViewFileSystem to return a trashRoot that is inside a mount point.
*/
- String CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH = "fs.viewfs.mount.point.local.trash";
- boolean CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT = false;
+ String CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT =
+ "fs.viewfs.trash.force-inside-mount-point";
+ boolean CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT = false;
Review comment:
I feel like this should default to true. I don't see any way that returning the old value (ie. the trash path from the underlying filesystem) using the underlying filesystem won't lead to failures.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java
##########
@@ -134,8 +134,9 @@
HCFSMountTableConfigLoader.class;
/**
- * Enable ViewFileSystem to return a trashRoot which is local to mount point.
+ * Force ViewFileSystem to return a trashRoot that is inside a mount point.
*/
- String CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH = "fs.viewfs.mount.point.local.trash";
- boolean CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT = false;
+ String CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT =
+ "fs.viewfs.trash.force-inside-mount-point";
+ boolean CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT = false;
Review comment:
I don't insist on this one, but this seems like a better default than the original behavior.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1192,59 +1219,66 @@ public Path getTrashRoot(Path path) {
trashRoots.addAll(fs.getTrashRoots(allUsers));
}
- // Add trash dirs for each mount point
- boolean useMountPointLocalTrash =
- config.getBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH,
- CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT);
- if (useMountPointLocalTrash) {
+ boolean trashForceInsideMountPoint =
+ config.getBoolean(CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT,
+ CONFIG_VIEWFS_TRASH_FORCE_INSIDE_MOUNT_POINT_DEFAULT);
+ // Return trashRoots if FORCE_INSIDE_MOUNT_POINT is disabled.
+ if (!trashForceInsideMountPoint) {
+ return trashRoots;
+ }
- Set<Path> currentTrashPaths = new HashSet<>();
- for (FileStatus file : trashRoots) {
- currentTrashPaths.add(file.getPath());
- }
+ // We use targetFS Path to check for duplicate paths.
+ Set<Path> uniqueTrashRoots = new HashSet<>();
+ for (FileStatus file : trashRoots) {
+ uniqueTrashRoots.add(file.getPath());
+ }
- MountPoint[] mountPoints = getMountPoints();
- try {
- for (int i = 0; i < mountPoints.length; i++) {
- Path trashRoot = makeQualified(
- new Path(mountPoints[i].mountedOnPath + "/" + TRASH_PREFIX));
+ List<InodeTree.MountPoint<FileSystem>> mountPoints =
+ fsState.getMountPoints();
+ try {
+ for (InodeTree.MountPoint<FileSystem> mountPoint : mountPoints) {
- // Continue if trashRoot does not exist for this filesystem
- if (!exists(trashRoot)) {
- continue;
- }
+ Path trashRoot = new Path(mountPoint.src + "/" + TRASH_PREFIX);
Review comment:
You need to make this fully qualified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] omalley commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
omalley commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r819927130
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1128,51 +1128,58 @@ public BlockStoragePolicySpi getStoragePolicy(Path src) throws IOException {
return allPolicies;
}
+ // Test whether a path is inside a snapshot or encrypted.
+ boolean isSnapshotEnabledOrEncrypted(Path p) throws IOException {
+ try {
+ FileStatus status = getFileStatus(p);
+ return status.isSnapshotEnabled() || status.isEncrypted();
Review comment:
There is more to the current code than this, and it is important. In particular, the snapshot only matters if they want the snapshot trash to stay inside the snapshot.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java
##########
@@ -134,8 +134,10 @@
HCFSMountTableConfigLoader.class;
/**
- * Enable ViewFileSystem to return a trashRoot which is local to mount point.
+ * Enable ViewFileSystem to return a trashRoot which is in the root dir of a
+ * mount point.
*/
- String CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH = "fs.viewfs.mount.point.local.trash";
- boolean CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT = false;
+ String CONFIG_VIEWFS_TRASH_ROOT_UNDER_MOUNT_POINT_ROOT =
+ "fs.viewfs.trash.root.under.mount.point.root";
Review comment:
Agreed. More consistent would be: fs.viewfs.trash.under-mount-root
##########
File path: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
##########
@@ -1141,60 +1143,52 @@ public void testTrashRootLocalizedTrash() throws IOException {
fsView2.getTrashRoot(nonExistentPath);
} catch (NotInMountpointException ignored) {
}
-
- // Case 5: path p is in the same mount point as targetFS.getTrashRoot().
- // Return targetFS.getTrashRoot()
- // Use a new Configuration object, so that we can start with an empty
- // mount table. This would avoid a conflict between the /user link in
- // setupMountPoints() and homeDir we will need to setup for this test.
- // default homeDir for hdfs is /user/.
- Configuration conf3 = ViewFileSystemTestSetup.createConfig();
- Path homeDir = fsTarget.getHomeDirectory();
- String homeParentDir = homeDir.getParent().toUri().getPath();
- conf3.setBoolean(CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH, true);
- ConfigUtil.addLink(conf3, homeParentDir,
- new Path(targetTestRoot, homeParentDir).toUri());
- Path homeTestPath = new Path(homeDir.toUri().getPath(), "testuser/file");
- FileSystem fsView3 = FileSystem.get(FsConstants.VIEWFS_URI, conf3);
- Assert.assertEquals(userTrashRoot, fsView3.getTrashRoot(homeTestPath));
}
/**
- * A mocked FileSystem which returns a deep trash dir.
+ * A mocked FileSystem which returns overwrites getFileStatus() to always
+ * return an encrypted FileStatus.
*/
static class MockTrashRootFS extends MockFileSystem {
Review comment:
+1
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
##########
@@ -1128,51 +1128,58 @@ public BlockStoragePolicySpi getStoragePolicy(Path src) throws IOException {
return allPolicies;
}
+ // Test whether a path is inside a snapshot or encrypted.
+ boolean isSnapshotEnabledOrEncrypted(Path p) throws IOException {
+ try {
+ FileStatus status = getFileStatus(p);
+ return status.isSnapshotEnabled() || status.isEncrypted();
Review comment:
Just in general, it isn't good to try to replicate the underlying filesystem's features.
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
##########
@@ -191,8 +191,8 @@ public boolean moveToTrash(Path path) throws IOException {
cause = e;
}
}
- throw (IOException)
- new IOException("Failed to move to trash: " + path).initCause(cause);
+ throw (IOException) new IOException(
Review comment:
Please revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1059717777
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 6s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 27s | | trunk passed |
| +1 :green_heart: | compile | 29m 51s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 23m 7s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 5s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 42s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 9s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 40s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 32s | | trunk passed |
| +1 :green_heart: | shadedclient | 25m 44s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 21s | | the patch passed |
| +1 :green_heart: | compile | 28m 40s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 28m 40s | | the patch passed |
| +1 :green_heart: | compile | 23m 32s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 23m 32s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 1s | [/results-checkstyle-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/3/artifact/out/results-checkstyle-hadoop-common-project_hadoop-common.txt) | hadoop-common-project/hadoop-common: The patch generated 1 new + 104 unchanged - 0 fixed = 105 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 41s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 7s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 36s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 49s | | the patch passed |
| +1 :green_heart: | shadedclient | 25m 32s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 18m 4s | [/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt) | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 48s | | The patch does not generate ASF License warnings. |
| | | 229m 57s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem |
| | hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 5870fc4e4f9f 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / a278cbccb6585cad126cc6793391a4484f5f3719 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/3/testReport/ |
| Max. process+thread count | 3137 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/3/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1062271773
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 48s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 33m 37s | | trunk passed |
| +1 :green_heart: | compile | 22m 40s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 19m 50s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 9s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 42s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 14s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 44s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 31s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 21s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 1s | | the patch passed |
| +1 :green_heart: | compile | 22m 3s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 22m 3s | | the patch passed |
| +1 :green_heart: | compile | 19m 54s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 19m 54s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 6s | | hadoop-common-project/hadoop-common: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 40s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 11s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 45s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 2m 43s | [/new-spotbugs-hadoop-common-project_hadoop-common.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/13/artifact/out/new-spotbugs-hadoop-common-project_hadoop-common.html) | hadoop-common-project/hadoop-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
| +1 :green_heart: | shadedclient | 22m 8s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 49s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 59s | | The patch does not generate ASF License warnings. |
| | | 200m 17s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hadoop-common-project/hadoop-common |
| | Call to org.apache.hadoop.fs.Path.equals(String) in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java: At ViewFileSystem.java:[line 1193] |
| | Call to String.equals(org.apache.hadoop.fs.Path) in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java: At ViewFileSystem.java:[line 1194] |
| | Nullcheck of mountTargetPath at line 1186 of value previously dereferenced in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java:1186 of value previously dereferenced in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java:[line 1186] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/13/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a4bbf9cb77a1 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f77abb0e5c17bf75e999f978e7192071318f2152 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/13/testReport/ |
| Max. process+thread count | 1500 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/13/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1062312795
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 11s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 39m 27s | | trunk passed |
| +1 :green_heart: | compile | 29m 44s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 25m 17s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 5s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 0s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 18s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 44s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 55s | | trunk passed |
| +1 :green_heart: | shadedclient | 27m 56s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 9s | | the patch passed |
| +1 :green_heart: | compile | 27m 29s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 27m 29s | | the patch passed |
| +1 :green_heart: | compile | 24m 25s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 24m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 1m 4s | | hadoop-common-project/hadoop-common: The patch generated 0 new + 103 unchanged - 1 fixed = 103 total (was 104) |
| +1 :green_heart: | mvnsite | 1m 52s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 18s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 1m 47s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 2m 56s | [/new-spotbugs-hadoop-common-project_hadoop-common.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/12/artifact/out/new-spotbugs-hadoop-common-project_hadoop-common.html) | hadoop-common-project/hadoop-common generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
| +1 :green_heart: | shadedclient | 28m 27s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 19m 11s | | hadoop-common in the patch passed. |
| +1 :green_heart: | asflicense | 0m 52s | | The patch does not generate ASF License warnings. |
| | | 242m 27s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hadoop-common-project/hadoop-common |
| | Call to org.apache.hadoop.fs.Path.equals(String) in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java: At ViewFileSystem.java:[line 1193] |
| | Call to String.equals(org.apache.hadoop.fs.Path) in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java: At ViewFileSystem.java:[line 1194] |
| | Nullcheck of mountTargetPath at line 1186 of value previously dereferenced in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java:1186 of value previously dereferenced in org.apache.hadoop.fs.viewfs.ViewFileSystem.getTrashRoot(Path) At ViewFileSystem.java:[line 1186] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/12/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 9c5b7ab3844c 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 4d27c7593cc3c5a98152da54e484ec5908397bce |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/12/testReport/ |
| Max. process+thread count | 3137 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/12/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xinglin commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
xinglin commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r820035684
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
##########
@@ -191,8 +191,8 @@ public boolean moveToTrash(Path path) throws IOException {
cause = e;
}
}
- throw (IOException)
- new IOException("Failed to move to trash: " + path).initCause(cause);
+ throw (IOException) new IOException(
Review comment:
Technically, this change is not related with our new trash policy. However, during the debugging process, we found it quite difficult to track where the file is being moved when we failed to do so. moveToTrash() function does not print the trash root path. Thus, I added this change when we failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] omalley commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
omalley commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r819950355
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java
##########
@@ -134,8 +134,10 @@
HCFSMountTableConfigLoader.class;
/**
- * Enable ViewFileSystem to return a trashRoot which is local to mount point.
+ * Enable ViewFileSystem to return a trashRoot which is in the root dir of a
+ * mount point.
*/
- String CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH = "fs.viewfs.mount.point.local.trash";
- boolean CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT = false;
+ String CONFIG_VIEWFS_TRASH_ROOT_UNDER_MOUNT_POINT_ROOT =
+ "fs.viewfs.trash.root.under.mount.point.root";
Review comment:
It still should use the "." as hierarchy and "-" between words.
I guess closer would be:
fs.viewfs.trash.force-inside-mount-point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] xinglin commented on a change in pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
xinglin commented on a change in pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#discussion_r819943782
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java
##########
@@ -134,8 +134,10 @@
HCFSMountTableConfigLoader.class;
/**
- * Enable ViewFileSystem to return a trashRoot which is local to mount point.
+ * Enable ViewFileSystem to return a trashRoot which is in the root dir of a
+ * mount point.
*/
- String CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH = "fs.viewfs.mount.point.local.trash";
- boolean CONFIG_VIEWFS_MOUNT_POINT_LOCAL_TRASH_DEFAULT = false;
+ String CONFIG_VIEWFS_TRASH_ROOT_UNDER_MOUNT_POINT_ROOT =
+ "fs.viewfs.trash.root.under.mount.point.root";
Review comment:
localized trash is not appropriate as the default hadoop implementation is already able to return a trash root that is within the mount point Filesystem. Thus, I renamed the new configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4034: HADOOP-18144. getTrashRoot/s in ViewFileSystem return a viewFS path
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #4034:
URL: https://github.com/apache/hadoop/pull/4034#issuecomment-1065896660
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 39s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 4 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 12m 50s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 26m 21s | | trunk passed |
| +1 :green_heart: | compile | 26m 45s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 22m 41s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 3m 51s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 35s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 40s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 3m 33s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 6m 48s | | trunk passed |
| +1 :green_heart: | shadedclient | 27m 54s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 34s | | the patch passed |
| +1 :green_heart: | compile | 24m 54s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 24m 54s | | the patch passed |
| +1 :green_heart: | compile | 22m 32s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 22m 32s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 3m 53s | | root: The patch generated 0 new + 110 unchanged - 1 fixed = 110 total (was 111) |
| +1 :green_heart: | mvnsite | 3m 25s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 30s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 3m 38s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 6m 48s | | the patch passed |
| +1 :green_heart: | shadedclient | 27m 4s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 18m 30s | | hadoop-common in the patch passed. |
| +1 :green_heart: | unit | 233m 14s | | hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 1m 10s | | The patch does not generate ASF License warnings. |
| | | 486m 21s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/18/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/4034 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 1e955159e185 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 485a650c1dd8115e3e0a56476b669791eeb192ef |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/18/testReport/ |
| Max. process+thread count | 3112 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4034/18/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org