You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Balázs Bence Sári <bs...@hortonworks.com> on 2017/09/28 00:06:00 UTC

Review Request 62649: AMBARI-21325: Quicklink support through Knox (new patch)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62649/
-----------------------------------------------------------

Review request for Ambari, Chandana Mirashi, Juanjo  Marron, Larry McCay, and Sid Wagle.


Bugs: AMBARI-21325
    https://issues.apache.org/jira/browse/AMBARI-21325


Repository: ambari


Description
-------

This is a continuation of Chandana Mirashi's patch reviewed here: https://reviews.apache.org/r/61043/
The original patch has been rebased and adapted to HDP-2.6 environment. Future HDP-3.0 compatibility has also been addressed.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 1d2e712 
  ambari-server/src/main/resources/common-services/HBASE/2.0.0.3.0/quicklinks/quicklinks.json 5568122 
  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/quicklinks/quicklinks.json 5318ba0 
  ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 5f470ec 
  ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/quicklinks/quicklinks.json f15ddd7 
  ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/quicklinks/quicklinks.json 43cf641 
  ambari-server/src/main/resources/common-services/SPARK/2.2.0/quicklinks/quicklinks.json 4639272 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/quicklinks-mapred/quicklinks.json 5ffbc07 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/quicklinks/quicklinks.json 37248d0 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/quicklinks/quicklinks.json 5568122 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/quicklinks/quicklinks.json a4216e3 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/metainfo.xml 26496f7 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/OOZIE/quicklinks/quicklinks.json 43cf641 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks-mapred/quicklinks.json 36f71b5 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/quicklinks/quicklinks.json 0aca8e3 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/KNOX/configuration/topology.xml df4c1b4 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/metainfo.xml 66341c9 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/quicklinks/quicklinks.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json c3e3f94 
  ambari-web/app/views/common/quick_view_link_view.js 5888acb 


Diff: https://reviews.apache.org/r/62649/diff/1/


Testing
-------

Manually tested with trunk version of Ambari and HDP-2.6. All quick links work except Spark2 ones as those would need the 2.1.0 version of SPARKHISTORYUI service definition.

All unit tests for ambari-server and ambari-web passed.


Thanks,

Balázs Bence Sári