You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "runqi-zhao (via GitHub)" <gi...@apache.org> on 2023/10/10 12:58:51 UTC
[PR] [future:init]:init ingress controller brpc [shenyu]
runqi-zhao opened a new pull request, #5204:
URL: https://github.com/apache/shenyu/pull/5204
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [future:init]:init ingress controller brpc [shenyu]
Posted by "JooKS-me (via GitHub)" <gi...@apache.org>.
JooKS-me merged PR #5204:
URL: https://github.com/apache/shenyu/pull/5204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [future:init]:init ingress controller brpc [shenyu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5204:
URL: https://github.com/apache/shenyu/pull/5204#issuecomment-1755566817
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5204?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5204](https://app.codecov.io/gh/apache/shenyu/pull/5204?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4bab753) into [master](https://app.codecov.io/gh/apache/shenyu/commit/9b54b985df55e1e9eaa87a350763fba6dc97ef55?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9b54b98) will **decrease** coverage by `0.17%`.
> The diff coverage is `55.20%`.
> :exclamation: Current head 4bab753 differs from pull request most recent head 60ea95e. Consider uploading reports for the commit 60ea95e to get more accurate results
```diff
@@ Coverage Diff @@
## master #5204 +/- ##
============================================
- Coverage 61.87% 61.71% -0.17%
- Complexity 8576 8587 +11
============================================
Files 1246 1247 +1
Lines 37699 37890 +191
Branches 3569 3593 +24
============================================
+ Hits 23327 23383 +56
- Misses 12333 12450 +117
- Partials 2039 2057 +18
```
| [Files](https://app.codecov.io/gh/apache/shenyu/pull/5204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/shenyu/k8s/common/IngressConstants.java](https://app.codecov.io/gh/apache/shenyu/pull/5204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWt1YmVybmV0ZXMtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2s4cy9jb21tb24vSW5ncmVzc0NvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | |
| [...va/org/apache/shenyu/k8s/parser/IngressParser.java](https://app.codecov.io/gh/apache/shenyu/pull/5204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWt1YmVybmV0ZXMtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2s4cy9wYXJzZXIvSW5ncmVzc1BhcnNlci5qYXZh) | `88.88% <100.00%> (+1.08%)` | :arrow_up: |
| [...pache/shenyu/k8s/reconciler/IngressReconciler.java](https://app.codecov.io/gh/apache/shenyu/pull/5204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWt1YmVybmV0ZXMtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2s4cy9yZWNvbmNpbGVyL0luZ3Jlc3NSZWNvbmNpbGVyLmphdmE=) | `60.94% <66.66%> (+0.11%)` | :arrow_up: |
| [.../java/org/apache/shenyu/k8s/parser/BrpcParser.java](https://app.codecov.io/gh/apache/shenyu/pull/5204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWt1YmVybmV0ZXMtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2s4cy9wYXJzZXIvQnJwY1BhcnNlci5qYXZh) | `53.84% <53.84%> (ø)` | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5204/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org