[GitHub] [inlong] gong commented on a diff in pull request #7750: [INLONG-7554][Sort] MySQL CDC supports parsing gh-ost records

["gong (via GitHub)" <gi...@apache.org>]

gong commented on code in PR #7750:
URL: https://github.com/apache/inlong/pull/7750#discussion_r1173258301


##########
inlong-sort/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/source/split/MySqlSplitSerializer.java:
##########
@@ -226,6 +258,7 @@ public byte[] serialize(MySqlSplit split) throws IOException {
             writeBinlogPosition(binlogSplit.getEndingOffset(), out);
             writeFinishedSplitsInfo(binlogSplit.getFinishedSnapshotSplitInfos(), out);
             writeTableSchemas(binlogSplit.getTableSchemas(), out);
+            writeTableDdls(binlogSplit.getTableDdls(), out);
             out.writeInt(binlogSplit.getTotalFinishedSplitSize());

Review Comment:
   invoke `writeTableDdls` and `readTableDdls` order could cause  compatibility issues.
   Because readTableDdls will cause error when state restore for old flink job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org