You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/30 11:22:15 UTC

[GitHub] [maven-mvnd] oehme opened a new pull request, #729: Reset system properties after calling event syps

oehme opened a new pull request, #729:
URL: https://github.com/apache/maven-mvnd/pull/729

   Event spies may want to read system properties, which will fail if they are reset too early. This change makes the behavior consistent with regular Maven.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-mvnd] ppalaga commented on pull request #729: Reset system properties after calling event syps

Posted by GitBox <gi...@apache.org>.
ppalaga commented on PR #729:
URL: https://github.com/apache/maven-mvnd/pull/729#issuecomment-1343412672

   You meant this one @guylabs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-mvnd] oehme commented on pull request #729: Reset system properties after calling event syps

Posted by GitBox <gi...@apache.org>.
oehme commented on PR #729:
URL: https://github.com/apache/maven-mvnd/pull/729#issuecomment-1341253639

   We have put a hacky workaround into our extension (capturing the system properties early in the build), but it would be great if you could merge this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-mvnd] gnodet merged pull request #729: Reset system properties after calling event syps

Posted by GitBox <gi...@apache.org>.
gnodet merged PR #729:
URL: https://github.com/apache/maven-mvnd/pull/729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-mvnd] guylabs commented on pull request #729: Reset system properties after calling event syps

Posted by GitBox <gi...@apache.org>.
guylabs commented on PR #729:
URL: https://github.com/apache/maven-mvnd/pull/729#issuecomment-1343446266

   @ppalaga Yes exactly :) All done already. Thanks for checking back on this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org