You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/08/28 07:53:07 UTC
Review Request 37873: Add quiesce logic in allocator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Add quiesce logic in allocator
Diffs
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
Diff: https://reviews.apache.org/r/37873/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97002
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37532, 37873]
All tests passed.
- Mesos ReviewBot
On Aug. 30, 2015, 12:57 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 12:57 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97051
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37532, 37873]
All tests passed.
- Mesos ReviewBot
On Aug. 31, 2015, 1:23 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 1:23 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/
-----------------------------------------------------------
(Updated 八月 31, 2015, 1:23 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
Add quiesce logic in allocator
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
Diff: https://reviews.apache.org/r/37873/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Guangya Liu <gy...@gmail.com>.
> On 八月 30, 2015, 5:10 p.m., Robert Lacroix wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 909
> > <https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line909>
> >
> > We need to store the information that a framework is quiescing offers in a more memory efficient way. This doesn't work for clusters with a lot of frameworks and a lot of slaves.
> >
> > Can't we just use a boolean to indicate the framework has quiesced?
The reason that I did not use a boolean value is because here quiesceOffers is a complement to the current reviveOffers, and reviveOffers can just clear the filters to enable the framework can get resource again, so here I was setting filters to this framework to disable it getting offers. For performance issue, the current settting are all memory operations and only for framework, I think that the Mesos cluster may not have thousands of frameworks. Comments? Thanks.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97031
-----------------------------------------------------------
On 八月 30, 2015, 12:57 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated 八月 30, 2015, 12:57 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by James Peach <jp...@apache.org>.
> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 909
> > <https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line909>
> >
> > We need to store the information that a framework is quiescing offers in a more memory efficient way. This doesn't work for clusters with a lot of frameworks and a lot of slaves.
> >
> > Can't we just use a boolean to indicate the framework has quiesced?
>
> Guangya Liu wrote:
> The reason that I did not use a boolean value is because here quiesceOffers is a complement to the current reviveOffers, and reviveOffers can just clear the filters to enable the framework can get resource again, so here I was setting filters to this framework to disable it getting offers. For performance issue, the current settting are all memory operations and only for framework, I think that the Mesos cluster may not have thousands of frameworks. Comments? Thanks.
>
> Robert Lacroix wrote:
> reviveOffers could just flip the boolean in addition to removing the filters, so that shouldn't make the logic much more complicated.
>
> The number of filters is indeed a problem because they (and all of their resources - which in case the ports are fragmented can be a lot) need to be traversed on every allocation.
>
> Guangya Liu wrote:
> Thanks Robert for the update. The design for quiesce offer also want a timeout for quiesce, if the timeout reached, then the framework can get resource offers automatically and no need for cluster admin to get involved to revive offer. Do you have any comments for adding a filter to quiesce offer? Is there are any other methods to add a filter which is more efficient? Hope can get some comments from you.
You can add the quiesce timeout using the mechanism that refuse timeouts use. It might get a little more involved since if you receive a second quiesce, you would need to update the timeout. You can't implement quiesce using a filter because filters are not ordered. You have to be able to check whether a framework is quiesced without traversing the whole filter set.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97031
-----------------------------------------------------------
On Aug. 31, 2015, 5:49 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 5:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Robert Lacroix <ma...@robertlacroix.com>.
> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 909
> > <https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line909>
> >
> > We need to store the information that a framework is quiescing offers in a more memory efficient way. This doesn't work for clusters with a lot of frameworks and a lot of slaves.
> >
> > Can't we just use a boolean to indicate the framework has quiesced?
>
> Guangya Liu wrote:
> The reason that I did not use a boolean value is because here quiesceOffers is a complement to the current reviveOffers, and reviveOffers can just clear the filters to enable the framework can get resource again, so here I was setting filters to this framework to disable it getting offers. For performance issue, the current settting are all memory operations and only for framework, I think that the Mesos cluster may not have thousands of frameworks. Comments? Thanks.
reviveOffers could just flip the boolean in addition to removing the filters, so that shouldn't make the logic much more complicated.
The number of filters is indeed a problem because they (and all of their resources - which in case the ports are fragmented can be a lot) need to be traversed on every allocation.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97031
-----------------------------------------------------------
On Aug. 31, 2015, 1:23 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 1:23 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Guangya Liu <gy...@gmail.com>.
> On 八月 30, 2015, 5:10 p.m., Robert Lacroix wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 153
> > <https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line153>
> >
> > Are we quiescing resources or rather offers? I think it should be called `quiesceOffers` so it's symmetrical to `reviveOffers`.
>
> Alexander Rukletsov wrote:
> Technically, allocator does not know anything about offers, only about allocations. This may change soon (we think about pulling offers management into allocator), but until then I find this naming misleading.
Alex, what about addressing this in future patches after pulling offers management into allocator landed? Thanks.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97031
-----------------------------------------------------------
On 九月 4, 2015, 2:19 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated 九月 4, 2015, 2:19 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp cb4020dea897ef198cd9898cabecf61edfade834
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
> src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 153
> > <https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line153>
> >
> > Are we quiescing resources or rather offers? I think it should be called `quiesceOffers` so it's symmetrical to `reviveOffers`.
Technically, allocator does not know anything about offers, only about allocations. This may change soon (we think about pulling offers management into allocator), but until then I find this naming misleading.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97031
-----------------------------------------------------------
On Aug. 31, 2015, 5:49 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 5:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Guangya Liu <gy...@gmail.com>.
> On 八月 30, 2015, 5:10 p.m., Robert Lacroix wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 909
> > <https://reviews.apache.org/r/37873/diff/3/?file=1059860#file1059860line909>
> >
> > We need to store the information that a framework is quiescing offers in a more memory efficient way. This doesn't work for clusters with a lot of frameworks and a lot of slaves.
> >
> > Can't we just use a boolean to indicate the framework has quiesced?
>
> Guangya Liu wrote:
> The reason that I did not use a boolean value is because here quiesceOffers is a complement to the current reviveOffers, and reviveOffers can just clear the filters to enable the framework can get resource again, so here I was setting filters to this framework to disable it getting offers. For performance issue, the current settting are all memory operations and only for framework, I think that the Mesos cluster may not have thousands of frameworks. Comments? Thanks.
>
> Robert Lacroix wrote:
> reviveOffers could just flip the boolean in addition to removing the filters, so that shouldn't make the logic much more complicated.
>
> The number of filters is indeed a problem because they (and all of their resources - which in case the ports are fragmented can be a lot) need to be traversed on every allocation.
Thanks Robert for the update. The design for quiesce offer also want a timeout for quiesce, if the timeout reached, then the framework can get resource offers automatically and no need for cluster admin to get involved to revive offer. Do you have any comments for adding a filter to quiesce offer? Is there are any other methods to add a filter which is more efficient? Hope can get some comments from you.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97031
-----------------------------------------------------------
On 八月 31, 2015, 5:49 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated 八月 31, 2015, 5:49 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Robert Lacroix <ma...@robertlacroix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review97031
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (line 153)
<https://reviews.apache.org/r/37873/#comment152744>
Are we quiescing resources or rather offers? I think it should be called `quiesceOffers` so it's symmetrical to `reviveOffers`.
src/master/allocator/mesos/hierarchical.hpp (line 909)
<https://reviews.apache.org/r/37873/#comment152743>
We need to store the information that a framework is quiescing offers in a more memory efficient way. This doesn't work for clusters with a lot of frameworks and a lot of slaves.
Can't we just use a boolean to indicate the framework has quiesced?
- Robert Lacroix
On Aug. 30, 2015, 12:57 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2015, 12:57 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add quiesce logic in allocator
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
> src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
>
> Diff: https://reviews.apache.org/r/37873/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/
-----------------------------------------------------------
(Updated Aug. 30, 2015, 12:57 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
Add quiesce logic in allocator
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
Diff: https://reviews.apache.org/r/37873/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/
-----------------------------------------------------------
(Updated Aug. 29, 2015, 2:59 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
Add quiesce logic in allocator
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
src/tests/mesos.hpp b2160f50db3e0b0d04b0625e7589004016c0f746
Diff: https://reviews.apache.org/r/37873/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 37873: Add quiesce logic in allocator
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/
-----------------------------------------------------------
(Updated Aug. 28, 2015, 5:55 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037
Repository: mesos
Description
-------
Add quiesce logic in allocator
Diffs
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
Diff: https://reviews.apache.org/r/37873/diff/
Testing
-------
Thanks,
Guangya Liu