You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/18 16:10:30 UTC
[GitHub] [superset] kgabryje opened a new pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
kgabryje opened a new pull request #14693:
URL: https://github.com/apache/superset/pull/14693
### SUMMARY
When user focuses on a native filter (hovers over it or opens select menu), highlight all charts in scope of that native filter (by adding a box shadow around it) and hide the charts outside of scope (by setting opacity to 0.3).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/15073128/118685945-d4d3e000-b803-11eb-9de2-6aaff0088e37.mov
### TEST PLAN
Set `DASHBOARD_NATIVE_FILTERS` feature flag to true.
Add some native filters to the dashboard - be creative with setting their scopes π
Verify that when you hover over Range or Time filter buttons, charts inside the scopes of those filters get highlighted and all other charts are less visible.
Verify that when you open a select menu of Select, Time Column, Time Grain and Group By filters, charts inside the scopes of those filters get highlighted and all other charts are less visible.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC: @junlincc @villebro @suddjian
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843608297
# [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14693](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cad4fd) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **decrease** coverage by `0.03%`.
> The diff coverage is `43.10%`.
> :exclamation: Current head 3cad4fd differs from pull request most recent head 59bdf14. Consider uploading reports for the commit 59bdf14 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14693 +/- ##
==========================================
- Coverage 77.51% 77.48% -0.04%
==========================================
Files 958 958
Lines 48560 48605 +45
Branches 5703 5708 +5
==========================================
+ Hits 37642 37662 +20
- Misses 10718 10743 +25
Partials 200 200
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `72.47% <43.10%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.77% <ΓΈ> (+0.94%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `77.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...filters/components/GroupBy/GroupByFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L0dyb3VwQnlGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `22.22% <0.00%> (-11.12%)` | :arrow_down: |
| [...t-frontend/src/filters/components/GroupBy/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `0.00% <0.00%> (ΓΈ)` | |
| [...end/src/filters/components/Range/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS90cmFuc2Zvcm1Qcm9wcy50cw==) | `12.50% <0.00%> (-7.50%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...rset-frontend/src/filters/components/Time/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32f5f36...59bdf14](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #14693:
URL: https://github.com/apache/superset/pull/14693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843637627
@kgabryje i believe in the original implementation, when there are multiple tabs, tabs light up if any charts in that tab is mapped to a specific filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-844269731
> @junlincc Are you sure that tabs were getting highlighted? I don't see the relevant code and there are no tabs highlights in the gif from Grace's comment here [#10936 (comment)](https://github.com/apache/superset/pull/10936#issuecomment-707224331)
For filter_box, we don't highlight tabs when only charts inside inactive tab will be impacted. We had this behavior is because filter_box could be placed inside tab. So that if a filter_box only has smaller tab scope, it should be placed inside the tab. It is possible that user sets a filter_box is applicable to multiple tabs but hide the filter_box inside a nested tab, but this case is small (why would someone do that?)
For build-in filter components, things are a little different: every filter component become globally visible in the dashboard, not matter it is applicable to single nested tab or multiple top-level tabs. This change might need us to think about the highlight behavior:
- When a filter component is applicable to a nested tab and currently user can not see the nested tab, filter component should be inactive (not in the current implementation but i assume this is in the near future), i think we still should highlight the scope even for the inactive filter component, so that user will know why the filter is not active now and what is its real scope. We should highlight the parent tab which is visible for the user when the charts are deep nested under other tabs.
- When a filter component is applicable to one more charts/tabs in the current active tab, filter component is active, we should highlight charts and tabs, so that behavior is consistent with above case.
want to hear ideas from @junlincc and @mihir174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843608297
# [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14693](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cad4fd) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **decrease** coverage by `0.03%`.
> The diff coverage is `43.10%`.
> :exclamation: Current head 3cad4fd differs from pull request most recent head 59bdf14. Consider uploading reports for the commit 59bdf14 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14693 +/- ##
==========================================
- Coverage 77.51% 77.48% -0.04%
==========================================
Files 958 958
Lines 48560 48605 +45
Branches 5703 5708 +5
==========================================
+ Hits 37642 37662 +20
- Misses 10718 10743 +25
Partials 200 200
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `72.47% <43.10%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.77% <ΓΈ> (+0.94%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `77.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...filters/components/GroupBy/GroupByFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L0dyb3VwQnlGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `22.22% <0.00%> (-11.12%)` | :arrow_down: |
| [...t-frontend/src/filters/components/GroupBy/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `0.00% <0.00%> (ΓΈ)` | |
| [...end/src/filters/components/Range/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS90cmFuc2Zvcm1Qcm9wcy50cw==) | `12.50% <0.00%> (-7.50%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...rset-frontend/src/filters/components/Time/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32f5f36...59bdf14](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843608297
# [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14693](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cad4fd) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **decrease** coverage by `0.03%`.
> The diff coverage is `43.10%`.
> :exclamation: Current head 3cad4fd differs from pull request most recent head a2e0bed. Consider uploading reports for the commit a2e0bed to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14693 +/- ##
==========================================
- Coverage 77.51% 77.48% -0.04%
==========================================
Files 958 958
Lines 48560 48605 +45
Branches 5703 5708 +5
==========================================
+ Hits 37642 37662 +20
- Misses 10718 10743 +25
Partials 200 200
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `72.47% <43.10%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.77% <ΓΈ> (+0.94%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `77.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...filters/components/GroupBy/GroupByFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L0dyb3VwQnlGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `22.22% <0.00%> (-11.12%)` | :arrow_down: |
| [...t-frontend/src/filters/components/GroupBy/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `0.00% <0.00%> (ΓΈ)` | |
| [...end/src/filters/components/Range/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS90cmFuc2Zvcm1Qcm9wcy50cw==) | `12.50% <0.00%> (-7.50%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...rset-frontend/src/filters/components/Time/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32f5f36...a2e0bed](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843414684
Could you create a sample dashboard with some Tabs, and set filter scope that is only applicable to those charts inside tab?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #14693:
URL: https://github.com/apache/superset/pull/14693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-844269731
> @junlincc Are you sure that tabs were getting highlighted? I don't see the relevant code and there are no tabs highlights in the gif from Grace's comment here [#10936 (comment)](https://github.com/apache/superset/pull/10936#issuecomment-707224331)
For filter_box, we don't highlight tabs when only charts inside inactive tab will be impacted. We had this behavior is because filter_box could be placed inside tab. So that if a filter_box only has smaller tab scope, it should be placed inside the tab. It is possible that user sets a filter_box is applicable to multiple tabs but hide the filter_box inside a nested tab, but this case is small (why would someone do that?)
For build-in filter components, things are a little different: every filter component become globally visible in the dashboard, not matter it is applicable to single nested tab or multiple top-level tabs. This change might need us to think about the highlight behavior:
- When a filter component is applicable to a nested tab and currently user can not see the nested tab, filter component should be inactive (not in the current implementation but i assume this is in the near future), i think we still should highlight the scope even for the inactive filter component, so that user will know why the filter is not active now and what is its real scope. We should highlight the parent tab which is visible for the user when the charts are deep nested under other tabs.
- When a filter component is applicable to one more charts/tabs in the current active tab, filter component is active, we should highlight charts and tabs, so that behavior is consistent with above case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #14693:
URL: https://github.com/apache/superset/pull/14693#discussion_r636191990
##########
File path: superset-frontend/src/filters/components/GroupBy/types.ts
##########
@@ -40,6 +40,8 @@ export type PluginFilterGroupByProps = PluginFilterStylesProps & {
behaviors: Behavior[];
data: DataRecord[];
setDataMask: SetDataMaskHook;
+ setFocusedFilter: () => void;
+ unsetFocusedFilter: () => void;
Review comment:
Good point, done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pseudoPixels commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
pseudoPixels commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-892307126
This feature is very intuitive and useful for dashboard users.
However, for some reason this feature is not working for our case (using Superset 1.2). Is there any special feature flag or so that we need to set to enable this? We do not get any error log/info, not sure whats we are missing. Can anyone please hint on it for possible issue? Many thanks all :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843608297
# [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14693](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cad4fd) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **decrease** coverage by `0.03%`.
> The diff coverage is `43.10%`.
> :exclamation: Current head 3cad4fd differs from pull request most recent head 759891d. Consider uploading reports for the commit 759891d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14693 +/- ##
==========================================
- Coverage 77.51% 77.48% -0.04%
==========================================
Files 958 958
Lines 48560 48605 +45
Branches 5703 5708 +5
==========================================
+ Hits 37642 37662 +20
- Misses 10718 10743 +25
Partials 200 200
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `72.47% <43.10%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.77% <ΓΈ> (+0.94%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `77.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...filters/components/GroupBy/GroupByFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L0dyb3VwQnlGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `22.22% <0.00%> (-11.12%)` | :arrow_down: |
| [...t-frontend/src/filters/components/GroupBy/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `0.00% <0.00%> (ΓΈ)` | |
| [...end/src/filters/components/Range/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS90cmFuc2Zvcm1Qcm9wcy50cw==) | `12.50% <0.00%> (-7.50%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...rset-frontend/src/filters/components/Time/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32f5f36...759891d](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
graceguo-supercat edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-844269731
> @junlincc Are you sure that tabs were getting highlighted? I don't see the relevant code and there are no tabs highlights in the gif from Grace's comment here [#10936 (comment)](https://github.com/apache/superset/pull/10936#issuecomment-707224331)
For filter_box, we don't highlight tabs when only charts inside inactive tab will be impacted. We had this behavior is because filter_box could be placed inside tab. So that if a filter_box only has smaller tab scope, it should be placed inside the tab. It is possible that user sets a filter_box is applicable to multiple tabs but hide the filter_box inside a nested tab, but this case is small (why would someone do that?)
For build-in filter components, things are a little different: every filter component become globally visible in the dashboard, not matter it is applicable to single nested tab or multiple top-level tabs. This change might need us to think about the highlight behavior:
- When a filter component is applicable to a nested tab and currently user can not see the nested tab, filter component should be inactive (not in the current implementation but i assume this is in the near future), i think we still should highlight the scope even for the inactive filter component, so that user will know why the filter is not active now and what is its real scope. We should highlight the parent tab which is visible for the user when the charts are deep nested under other tabs.
- When a filter component is applicable to one more charts/tabs in the current active tab, filter component is active, we should highlight charts and tabs, so that behavior is consistent with above case.
cc @junlincc want to hear you and designer ideas too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843608297
# [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14693](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74c4ec5) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **decrease** coverage by `0.04%`.
> The diff coverage is `43.10%`.
[](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14693 +/- ##
==========================================
- Coverage 77.51% 77.46% -0.05%
==========================================
Files 958 959 +1
Lines 48560 48733 +173
Branches 5703 6115 +412
==========================================
+ Hits 37642 37752 +110
- Misses 10718 10778 +60
- Partials 200 203 +3
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `72.45% <43.10%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...components/DashboardBuilder/DashboardContainer.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQ29udGFpbmVyLnRzeA==) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.77% <ΓΈ> (+0.94%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `77.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...filters/components/GroupBy/GroupByFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L0dyb3VwQnlGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `22.22% <0.00%> (-11.12%)` | :arrow_down: |
| [...t-frontend/src/filters/components/GroupBy/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `0.00% <0.00%> (ΓΈ)` | |
| [...end/src/filters/components/Range/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS90cmFuc2Zvcm1Qcm9wcy50cw==) | `12.50% <0.00%> (-7.50%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ΓΈ> (ΓΈ)` | |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32f5f36...74c4ec5](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-844180326
> Are you sure that tabs were getting highlighted?
got it, that was in the design but never implemented....π
;let's spend a day or 2 to add this feature in a seperate PR
- highlight other tabs that have charts scoped to the filter, when user is in a different tab.
- when user switch to the highlighted tab, user see highlighted charts in tab
- please open a separate PR to disable animation in tab globally @ktmud
- please open a separate PR to grey out filters that are not scoped to a specific tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #14693:
URL: https://github.com/apache/superset/pull/14693#discussion_r636184338
##########
File path: superset-frontend/src/dashboard/actions/nativeFilters.ts
##########
@@ -116,7 +116,7 @@ type BootstrapData = {
};
};
-export interface SetBooststapData {
+export interface SetBootstrapData {
Review comment:
π Ah boost... I remember that I was so happy when C++11 (I think?) was released and they added a lot of stuff from boost to std π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-845434122
@graceguo-supercat
for current iteration - we will grey out filters that are not scoped to tabs from the filter bar, as just a visual suggestion that the specific filter wonβt apply in the current scope(instead of disabling it). This should reach feature parity with filter box highlighting behavior
For range filter, blue circle will be greyed out; for time range, color darker grey on hovering
<img width="234" alt="Screen Shot 2021-05-20 at 9 57 41 AM" src="https://user-images.githubusercontent.com/67837651/119040842-c2c08180-b96a-11eb-86b8-8a67c1695906.png">
Above change will be made in separate PRs
We can discuss next iteration, including grouping or foldering filters to tabs(but not now). π
@kgabryje please go ahead and merge your PR, I will take a deeper look once multiple native filter PRs are all merged.
cc @michael-s-molina
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] graceguo-supercat commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843414684
Could you create a sample dashboard with some Tabs, and set filter scope for those charts inside tab?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843940456
@graceguo-supercat @junlincc Thank you for comments! The charts inside of tabs are correctly highlighted, however if a chart in filter's scope is in an inactive tab, that tab doesn't get highlighted - I'll try to implement that.
@junlincc Are you sure that tabs were getting highlighted? I don't see the relevant code and there are no tabs highlights in the gif from Grace's comment here https://github.com/apache/superset/pull/10936#issuecomment-707224331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843637627
@kgabryje i believe in the original implementation, when there are multiple tabs, tabs light up if any charts in the tab is mapped to a specific filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #14693:
URL: https://github.com/apache/superset/pull/14693#discussion_r635109689
##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
##########
@@ -72,7 +72,7 @@ const DashboardContainer: FC<DashboardContainerProps> = ({ topLevelTabs }) => {
activeKey={activeKey}
renderTabBar={() => <></>}
fullWidth={false}
- animated
+ animated={false}
Review comment:
I disabled animation as it was breaking native filters - when user switched tab, `margin-left: 100%` style was set on tab content, which was covering native filters panel, causing the user to be unable to click native filters... And the animation looked ugly with native filters panel anyway π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #14693:
URL: https://github.com/apache/superset/pull/14693#discussion_r636056270
##########
File path: superset-frontend/src/dashboard/actions/nativeFilters.ts
##########
@@ -116,7 +116,7 @@ type BootstrapData = {
};
};
-export interface SetBooststapData {
+export interface SetBootstrapData {
Review comment:
This gave me fond memories of C++ https://www.boost.org/
##########
File path: superset-frontend/src/filters/components/common.ts
##########
@@ -21,8 +21,8 @@ import { Select } from 'src/common/components';
import { PluginFilterStylesProps } from './types';
export const Styles = styled.div<PluginFilterStylesProps>`
- height: ${({ height }) => height};
- width: ${({ width }) => width};
+ height: ${({ height }) => height}px;
+ width: ${({ width }) => width}px;
Review comment:
oh one of these again π
##########
File path: superset-frontend/src/filters/components/GroupBy/types.ts
##########
@@ -40,6 +40,8 @@ export type PluginFilterGroupByProps = PluginFilterStylesProps & {
behaviors: Behavior[];
data: DataRecord[];
setDataMask: SetDataMaskHook;
+ setFocusedFilter: () => void;
+ unsetFocusedFilter: () => void;
Review comment:
Simplification idea: we could move the `setDataMask`, `setFocusedFilter` and `unsetFocusedFilter` into a shared interface/type `PluginFilterHooks` in `filters/components/types.ts` and then just `&` them into `PluginFilterGroupByProps` and the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843608297
# [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14693](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cad4fd) into [master](https://codecov.io/gh/apache/superset/commit/32f5f365d8635851a39b299b2ce6c319a839cade?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32f5f36) will **decrease** coverage by `0.03%`.
> The diff coverage is `43.10%`.
> :exclamation: Current head 3cad4fd differs from pull request most recent head 74c4ec5. Consider uploading reports for the commit 74c4ec5 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14693 +/- ##
==========================================
- Coverage 77.51% 77.48% -0.04%
==========================================
Files 958 958
Lines 48560 48605 +45
Branches 5703 5708 +5
==========================================
+ Hits 37642 37662 +20
- Misses 10718 10743 +25
Partials 200 200
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `72.47% <43.10%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.77% <ΓΈ> (+0.94%)` | :arrow_up: |
| [...nents/nativeFilters/FilterBar/FilterSets/index.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvaW5kZXgudHN4) | `77.00% <ΓΈ> (ΓΈ)` | |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <ΓΈ> (ΓΈ)` | |
| [...filters/components/GroupBy/GroupByFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L0dyb3VwQnlGaWx0ZXJQbHVnaW4udHN4) | `0.00% <0.00%> (ΓΈ)` | |
| [...d/src/filters/components/GroupBy/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3RyYW5zZm9ybVByb3BzLnRz) | `22.22% <0.00%> (-11.12%)` | :arrow_down: |
| [...t-frontend/src/filters/components/GroupBy/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9Hcm91cEJ5L3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...src/filters/components/Range/RangeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9SYW5nZUZpbHRlclBsdWdpbi50c3g=) | `0.00% <0.00%> (ΓΈ)` | |
| [...end/src/filters/components/Range/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS90cmFuc2Zvcm1Qcm9wcy50cw==) | `12.50% <0.00%> (-7.50%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `100.00% <ΓΈ> (ΓΈ)` | |
| [...rset-frontend/src/filters/components/Time/types.ts](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL3R5cGVzLnRz) | `100.00% <ΓΈ> (ΓΈ)` | |
| ... and [16 more](https://codecov.io/gh/apache/superset/pull/14693/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32f5f36...74c4ec5](https://codecov.io/gh/apache/superset/pull/14693?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-845434122
@graceguo-supercat
for current iteration - we will grey out filters that are not scoped to tabs from the filter bar, as just a visual suggestion that the specific filter wonβt apply in the current scope(instead of disabling it). This should reach feature parity with filter box highlighting behavior
For range filter, blue circle will be greyed out; for time range, color darker grey on hovering
<img width="234" alt="Screen Shot 2021-05-20 at 9 57 41 AM" src="https://user-images.githubusercontent.com/67837651/119040842-c2c08180-b96a-11eb-86b8-8a67c1695906.png">
Above change will be made in separate PRs
We can discuss next iteration for grouping or foldering filter to tabs(but not now). π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-892432804
> This feature is very intuitive and useful for dashboard users.
> However, for some reason this feature is not working for our case (using Superset 1.2). Is there any special feature flag or so that we need to set to enable this? We do not get any error log/info, not sure whats we are missing. Can anyone please hint on it for possible issue? Many thanks all :)
I don't believe this PR made it into 1.2 - however, this should be available in 1.3 (forthcoming)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843940456
@graceguo-supercat @junlincc Thank you for your comments! The charts inside of tabs are correctly highlighted, however if a chart in filter's scope is in an inactive tab, that tab doesn't get highlighted - I'll try to implement that.
@junlincc Are you sure that tabs were getting highlighted? I don't see the relevant code and there are no tabs highlights in the gif from Grace's comment here https://github.com/apache/superset/pull/10936#issuecomment-707224331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje edited a comment on pull request #14693: feat(native-filters): Highlight charts affected by focused native filter
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on pull request #14693:
URL: https://github.com/apache/superset/pull/14693#issuecomment-843940456
@graceguo-supercat @junlincc Thank you for your comments! The charts inside of tabs are correctly highlighted. However, if a chart in filter's scope is in an inactive tab, that tab doesn't get highlighted - I'll try to implement that.
@junlincc Are you sure that tabs were getting highlighted? I don't see the relevant code and there are no tabs highlights in the gif from Grace's comment here https://github.com/apache/superset/pull/10936#issuecomment-707224331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org