[GitHub] thrift pull request #1035: nodejs client fails to import 'assert'

[edenhochbaum <gi...@git.apache.org>]

GitHub user edenhochbaum opened a pull request:

    https://github.com/apache/thrift/pull/1035

    nodejs client fails to import 'assert'

    So when the connection fails, we just get an error about assert not being defined (rather than details of the connection failure.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/edenhochbaum/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1035.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1035
    
----
commit 29be8ce89d7354bc68e5674051862cf1417fe011
Author: Eden Hochbaum <ed...@gmail.com>
Date:   2016-06-28T20:49:27Z

    NodeClient.js fails to import 'assert'

commit 5e852eda44341b232b4909341efdae8606920e84
Author: Eden Hochbaum <ed...@gmail.com>
Date:   2016-06-28T20:50:09Z

    NodeClientPromise.js fails to import 'assert'

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1035: nodejs client fails to import 'assert'

[edenhochbaum <gi...@git.apache.org>]

Github user edenhochbaum closed the pull request at:

    https://github.com/apache/thrift/pull/1035


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---