You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2014/04/19 02:09:16 UTC

[GitHub] spark pull request: Honor default fs name when initializing event ...

GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/450

    Honor default fs name when initializing event logger.

    This is related to SPARK-1459 / PR #375. Without this fix,
    FileLogger.createLogDir() may try to create the log dir on
    HDFS, while createWriter() will try to open the log file on
    the local file system, leading to interesting errors and
    confusion.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark event-file-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #450
    
----
commit e3c3e3fd7baee19b55ab82a4649dfa7d0919f2f8
Author: Marcelo Vanzin <va...@cloudera.com>
Date:   2014-04-11T20:12:34Z

    Honor default fs name when initializing event logger.
    
    This is related to SPARK-1459 / PR #375. Without this fix,
    FileLogger.createLogDir() may try to create the log dir on
    HDFS, while createWriter() will try to open the log file on
    the local file system, leading to interesting errors and
    confusion.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41199582
  
    Merged build finished. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41214235
  
    Jenkins, retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11877969
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -36,7 +37,9 @@ import org.apache.spark.util.{FileLogger, JsonProtocol}
      *   spark.eventLog.dir - Path to the directory in which events are logged.
      *   spark.eventLog.buffer.kb - Buffer size to use when writing to output streams
      */
    -private[spark] class EventLoggingListener(appName: String, conf: SparkConf)
    +private[spark] class EventLoggingListener(appName: String,
    --- End diff --
    
    nit: style should be
    
    ```
    private[spark] class EventLoggingListener(
        appName: String,
        ...
      extends ...
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11878317
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -86,10 +88,16 @@ private[spark] class FileLogger(
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
     
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
    +    val isDefaultLocal = (defaultFs == null || "file".equals(defaultFs))
    +
         /* The Hadoop LocalFileSystem (r1.0.4) has known issues with syncing (HADOOP-7844).
          * Therefore, for local files, use FileOutputStream instead. */
         val dstream = uri.getScheme match {
    -      case "file" | null =>
    +      case null if isDefaultLocal =>
    +        new FileOutputStream(uri.getPath, !overwrite)
    +
    +      case "file" =>
    --- End diff --
    
    Good point. That should work too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11813291
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -86,10 +88,17 @@ private[spark] class FileLogger(
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
     
    +    val defaultFs = new URI(hadoopConfiguration.get(FileSystem.FS_DEFAULT_NAME_KEY,
    --- End diff --
    
    FileSystem has a function to give you the default filesystem without you have to look at the configs directly:
    
    public static URI getDefaultUri(Configuration conf)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11878513
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -86,10 +88,16 @@ private[spark] class FileLogger(
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
     
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
    +    val isDefaultLocal = (defaultFs == null || "file".equals(defaultFs))
    --- End diff --
    
    and then down below I'd do
    
    ```
    val dstream =
      if (isLocal) {
        new FileOutputStream(uri.getPath, !overwrite)
      } else {
        // do the Hadoop stuff
      }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41007015
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41066263
  
    The ordering of initialization in the DAGScheduler is very sensitive. Could this patch instead just move the Hadoop configuration up? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11879006
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -85,11 +87,13 @@ private[spark] class FileLogger(
       private def createWriter(fileName: String): PrintWriter = {
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
    --- End diff --
    
    Old habits die hard (and scalac not complaining does not help).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11878383
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -86,10 +88,16 @@ private[spark] class FileLogger(
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
     
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
    +    val isDefaultLocal = (defaultFs == null || "file".equals(defaultFs))
    --- End diff --
    
    I would probably just call this `isLocal`, and set it to `defaultFs == null || uri.getScheme == "file"`. In Scala you can do `==` on strings :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41112649
  
    Thanks for the changes @vanzin. I think the logic is much more straightforward now. This LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41007019
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/450


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11879995
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -85,11 +87,13 @@ private[spark] class FileLogger(
       private def createWriter(fileName: String): PrintWriter = {
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
    --- End diff --
    
    ha, good catch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41218913
  
    Merged build finished. All automated tests passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41199584
  
    
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14378/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41188985
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11878962
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -85,11 +87,13 @@ private[spark] class FileLogger(
       private def createWriter(fileName: String): PrintWriter = {
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
    --- End diff --
    
    semi colon...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41009230
  
    
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14319/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41218919
  
    All automated tests passed.
    Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14398/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41214432
  
    Merged build started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41188638
  
    Jenkins, retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11880274
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -85,11 +87,13 @@ private[spark] class FileLogger(
       private def createWriter(fileName: String): PrintWriter = {
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme
    +    val isDefaultLocal = (defaultFs == null || "file".equals(defaultFs))
     
         /* The Hadoop LocalFileSystem (r1.0.4) has known issues with syncing (HADOOP-7844).
          * Therefore, for local files, use FileOutputStream instead. */
         val dstream = uri.getScheme match {
    -      case "file" | null =>
    +      case null | "file" if isDefaultLocal =>
    --- End diff --
    
    Actually, this is incorrect I think. If the default is not local, but the user specifies `file://` then this will use the next case and fail silently because of sync issues.
    
    By the way the logic is a little obfuscated to me right now. Since we only match on 2 cases here, I think it's more straightforward to write it out with `if-else`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11878289
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -86,10 +88,16 @@ private[spark] class FileLogger(
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
     
    --- End diff --
    
    nit: remove this new line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41219154
  
    Thanks - merged this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41214423
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11878199
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -86,10 +88,16 @@ private[spark] class FileLogger(
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
     
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
    +    val isDefaultLocal = (defaultFs == null || "file".equals(defaultFs))
    +
         /* The Hadoop LocalFileSystem (r1.0.4) has known issues with syncing (HADOOP-7844).
          * Therefore, for local files, use FileOutputStream instead. */
         val dstream = uri.getScheme match {
    -      case "file" | null =>
    +      case null if isDefaultLocal =>
    +        new FileOutputStream(uri.getPath, !overwrite)
    +
    +      case "file" =>
    --- End diff --
    
    Is there a case where the scheme is `file` but the default is not local? That is, if `file` always implies local then we can combine these two cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41188971
  
     Merged build triggered. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/450#discussion_r11878822
  
    --- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
    @@ -86,10 +88,16 @@ private[spark] class FileLogger(
         val logPath = logDir + "/" + fileName
         val uri = new URI(logPath)
     
    +    val defaultFs = FileSystem.getDefaultUri(hadoopConfiguration).getScheme;
    +    val isDefaultLocal = (defaultFs == null || "file".equals(defaultFs))
    --- End diff --
    
    That check wouldn't cover all cases. It would need to be:
    
      ((defaultFs == null || defaultFs == "file") && uri.getScheme == null)) || uri.getScheme == "file"
    
    (Which, btw, is the same check the pattern matcher is doing.) At that point I think the current code is more readable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-40855011
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41009229
  
    Merged build finished. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: Honor default fs name when initializing event ...

Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/450#issuecomment-41006843
  
    Jenkins, test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---