You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Antonio Sanso (JIRA)" <ji...@apache.org> on 2012/10/25 17:05:12 UTC

[jira] [Created] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Antonio Sanso created SLING-2629:
------------------------------------

             Summary: [Tooling] Add tycho build to Slingclipse
                 Key: SLING-2629
                 URL: https://issues.apache.org/jira/browse/SLING-2629
             Project: Sling
          Issue Type: Sub-task
          Components: Extensions
            Reporter: Antonio Sanso
            Priority: Minor




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Munteanu updated SLING-2629:
-----------------------------------

    Attachment: SLING-2629-tycho-build-2.txt
    
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build-1.diff, SLING-2629-tycho-build-2.txt, SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484464#comment-13484464 ] 

Robert Munteanu commented on SLING-2629:
----------------------------------------

Here's what should be the final build of the patch, with the following additions

- patch which actually works ( generated with svn diff )
- add a target platform definition based on indigo ( Eclipse 3.7 )
- set all versions to 0.0.1 , for consistency

Invoking mvn clean package in the project root will result in a p2 repository at slingclipse-p2update/target/repository/
                
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build-1.diff, SLING-2629-tycho-build-2.txt, SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484362#comment-13484362 ] 

Robert Munteanu commented on SLING-2629:
----------------------------------------

In reply to comment #4:
> I attached a new patch I created based on Robert's patch.  It seemed to work
> when I applied it to a new checkout locally.  Please check it out and let me
> know.

Thanks! I'll try and check the diffs and see what went wrong. I actually use git-svn so that's the source of the problems.
                
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build-1.diff, SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Dan Klco (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Klco updated SLING-2629:
----------------------------

    Attachment: SLING-2629-tycho-build-1.diff

I attached a new patch I created based on Robert's patch.  It seemed to work when I applied it to a new checkout locally.  Please check it out and let me know.
                
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build-1.diff, SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Dan Klco (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484310#comment-13484310 ] 

Dan Klco commented on SLING-2629:
---------------------------------

I'll second the issue, the patch does not seem to be working for me.  I tried through eclipse and the patch CLI tool.
                
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484810#comment-13484810 ] 

Antonio Sanso commented on SLING-2629:
--------------------------------------

Thanks for your patch Robert I have committed it in revision 1402456. Thanks as well Dan for your help!
                
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build-1.diff, SLING-2629-tycho-build-2.txt, SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484287#comment-13484287 ] 

Antonio Sanso commented on SLING-2629:
--------------------------------------

Hi Robert,

thanks a lot for the patch. I am having some issue to import it though. Is it actually an svn patch :S ?
I think we'd better start with version 0.0.1, right?
And eclipse version target wise I am still using Indigo and worked pretty well with it so having a lower prerequisite than Juno sounds reasonable,

                
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484198#comment-13484198 ] 

Robert Munteanu commented on SLING-2629:
----------------------------------------

First working version of a tycho build. This builds the plugin projects, adds a feature project, so that the plugins may be updated and a p2 repository so that they can be installed using regular Eclipse facilities.

I have verified that 'mvn package' ( and a little patience ) builds the p2 repository and the contents installs cleanly in Eclipse.

I've left the versions untouched, not sure what you plan the actual version to be ( 0.0.1 vs 1.0.0 ) . I still have a target file to add, so that can use for both building and developing in Eclipse as a baseline, but I'm not sure what version of Eclipse you want to target. I've started with Juno but probably we can have a pretty low Eclipse version as a prerequisite. Just let me know and I'll adjust it.
                
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Sanso reassigned SLING-2629:
------------------------------------

    Assignee: Antonio Sanso
    
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antonio Sanso resolved SLING-2629.
----------------------------------

    Resolution: Fixed
    
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build-1.diff, SLING-2629-tycho-build-2.txt, SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2629) [Tooling] Add tycho build to Slingclipse

Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Munteanu updated SLING-2629:
-----------------------------------

    Attachment: SLING-2629-tycho-build.diff
    
> [Tooling] Add tycho build to Slingclipse
> ----------------------------------------
>
>                 Key: SLING-2629
>                 URL: https://issues.apache.org/jira/browse/SLING-2629
>             Project: Sling
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Antonio Sanso
>            Assignee: Antonio Sanso
>            Priority: Minor
>         Attachments: SLING-2629-tycho-build.diff
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira